comparison mercurial/wireprotov2server.py @ 37557:734515aca84d

wireproto: define and implement HTTP handshake to upgrade protocol When clients connect to repositories over HTTP, they issue a request to the well-known URL "?cmd=capabilities" to fetch the repository capabilities. This is the handshake portion of the HTTP protocol. This commit defines a mechanism to use that HTTP request to return information about modern server features. If a client sends an X-HgUpgrade-* header containing a list of client-supported API names, the server responds with a response containing information about available services. This includes the normal capabilities string. So if the server doesn't support any newer services, the client can easily fall back. By advertising supported services from clients, server operators can see and log what client support exists in the wild. This will also help with debugging. The response contains the base path to API services. We know there are potential issues with the <repo>/api/ URL space conflicting with hgwebdir and subrepos. By making the API URL dynamic from the perspective of the client, the URL for APIs is not subject to backwards compatibility concerns - at least as long as a ?cmd=capabilities request is made. We've also defined the ``cbor`` client capability for the X-HgProto-* header. This MUST be sent in order to get the modern response from "?cmd=capabilities". During implementation, I initially always sent an application/mercurial-cbor response. However, the handshake mechanism will be more future compatible if the client is in charge of which formats to request. We already perform content negotiation from X-HgProto-*, so keying off this for the capabilities response feels appropriate. In addition, I initially used application/cbor. However, it is conceivable that a non-Mercurial server could serve application/cbor. To rule out this possibility, I've invented a new media type that is Mercurial specific and can't be confused for generic CBOR. Differential Revision: https://phab.mercurial-scm.org/D3242
author Gregory Szorc <gregory.szorc@gmail.com>
date Tue, 10 Apr 2018 14:29:15 -0700
parents 3a2367e6c6f2
children 77c9ee77687c
comparison
equal deleted inserted replaced
37556:b77aa48ba690 37557:734515aca84d
363 return caps 363 return caps
364 364
365 def checkperm(self, perm): 365 def checkperm(self, perm):
366 raise NotImplementedError 366 raise NotImplementedError
367 367
368 def httpv2apidescriptor(req, repo):
369 proto = httpv2protocolhandler(req, repo.ui)
370
371 return _capabilitiesv2(repo, proto)
372
368 def _capabilitiesv2(repo, proto): 373 def _capabilitiesv2(repo, proto):
369 """Obtain the set of capabilities for version 2 transports. 374 """Obtain the set of capabilities for version 2 transports.
370 375
371 These capabilities are distinct from the capabilities for version 1 376 These capabilities are distinct from the capabilities for version 1
372 transports. 377 transports.