comparison mercurial/repository.py @ 39244:73cf21b2e8a6

manifest: add getstorage() to manifestlog and use it globally It is a common pattern to obtain a directory manifest storage instance (a manifestrevlog) by going through manifestlog._revlog.dirlog(). Why access to storage and caching of other manifests is done through manifestrevlog instead of manifestlog, I don't know. This commit establishes a getstorage(tree) API on manifestlog and imanifestlog that provides a public API for accessing manifest storage. All consumers previously using private attributes have been updated to use this new method. .. api:: manifestlog now has a getstorage(tree) method It should be used for obtaining an object representing the manifest's storage implementation. Accessing manifestlog._revlog should be avoided. Differential Revision: https://phab.mercurial-scm.org/D4277
author Gregory Szorc <gregory.szorc@gmail.com>
date Fri, 10 Aug 2018 15:01:06 -0700
parents aad4b46e89bb
children 7f5e6d3e9032
comparison
equal deleted inserted replaced
39243:0d97530eb535 39244:73cf21b2e8a6
1021 1021
1022 The returned object conforms to the ``imanifestrevisionstored`` 1022 The returned object conforms to the ``imanifestrevisionstored``
1023 interface. 1023 interface.
1024 """ 1024 """
1025 1025
1026 def getstorage(tree):
1027 """Retrieve an interface to storage for a particular tree.
1028
1029 If ``tree`` is the empty bytestring, storage for the root manifest will
1030 be returned. Otherwise storage for a tree manifest is returned.
1031
1032 TODO formalize interface for returned object.
1033 """
1034
1026 def clearcaches(): 1035 def clearcaches():
1027 """Clear caches associated with this collection.""" 1036 """Clear caches associated with this collection."""
1028 1037
1029 def rev(node): 1038 def rev(node):
1030 """Obtain the revision number for a binary node. 1039 """Obtain the revision number for a binary node.