comparison mercurial/patch.py @ 43104:74802979dd9d

py3: define and use pycompat.itervalues() .itervalues() only exists on Python 2. Python 3's equivalent is .values(). But we don't want to blindly use .values() everywhere because on Python 2, it will create a list, which will have performance implications. This commit introduces pycompat.itervalues() which will call the appropriate method on the passed object. We update all callers of obj.itervalues() to pycompat.itervalues(obj) instead. With this commit, the only source tranforming remaining is for iteritems(). Victory is near... Differential Revision: https://phab.mercurial-scm.org/D7013
author Gregory Szorc <gregory.szorc@gmail.com>
date Sun, 06 Oct 2019 17:59:15 -0400
parents 27c4f93d07a9
children d783f945a701
comparison
equal deleted inserted replaced
43103:c95b2f40db7c 43104:74802979dd9d
1329 applied[newhunk.filename()].append(newhunk) 1329 applied[newhunk.filename()].append(newhunk)
1330 else: 1330 else:
1331 fixoffset += chunk.removed - chunk.added 1331 fixoffset += chunk.removed - chunk.added
1332 return ( 1332 return (
1333 sum( 1333 sum(
1334 [h for h in applied.itervalues() if h[0].special() or len(h) > 1], 1334 [
1335 h
1336 for h in pycompat.itervalues(applied)
1337 if h[0].special() or len(h) > 1
1338 ],
1335 [], 1339 [],
1336 ), 1340 ),
1337 {}, 1341 {},
1338 ) 1342 )
1339 1343