Mercurial > hg
comparison mercurial/context.py @ 23701:76320e2ed0a8
context: remove unreliable accessor methods from committablectx
There are two caching routes for (propertycache-ed) "_status" below in
committablectx:
- invoking "status()":
"dirstate.status()" is invoked, and the result of it is cached
into "_status". In this case, any of "listignored", "listclean"
and "listunknown" may be True.
- accessing "_status" directly before "status()":
Own "status()" is invoked, but all of "listignored", "listclean"
and "listunknown" arguments are False, in this case.
"ignored"/"clean"/"unknown" accessor methods of "committablectx" use
corresponded fields of "_status", but these fields aren't reliable,
because these fields are empty when:
- "_status" method is executed before accessors, or
- "status()" is executed with "list*=False" before accessors
In addition to it, these accessors aren't used in the recent Mercurial
implementation. At least, removing them doesn't cause any test
failures.
author | FUJIWARA Katsunori <foozy@lares.dti.ne.jp> |
---|---|
date | Wed, 31 Dec 2014 17:55:43 +0900 |
parents | a4958cdb2202 |
children | c48924787eaa |
comparison
equal
deleted
inserted
replaced
23700:a4958cdb2202 | 23701:76320e2ed0a8 |
---|---|
1110 return self._status.added | 1110 return self._status.added |
1111 def removed(self): | 1111 def removed(self): |
1112 return self._status.removed | 1112 return self._status.removed |
1113 def deleted(self): | 1113 def deleted(self): |
1114 return self._status.deleted | 1114 return self._status.deleted |
1115 def unknown(self): | |
1116 return self._status.unknown | |
1117 def ignored(self): | |
1118 return self._status.ignored | |
1119 def clean(self): | |
1120 return self._status.clean | |
1121 def branch(self): | 1115 def branch(self): |
1122 return encoding.tolocal(self._extra['branch']) | 1116 return encoding.tolocal(self._extra['branch']) |
1123 def closesbranch(self): | 1117 def closesbranch(self): |
1124 return 'close' in self._extra | 1118 return 'close' in self._extra |
1125 def extra(self): | 1119 def extra(self): |