comparison mercurial/wireproto.py @ 29151:7996c3acc33b

wireproto: optimize handling of large batch responses

Now that batch can be used by remotefilelog, the quadratic string
copying this was doing was actually disastrous. In my local testing,
fetching a 56 meg file used to take 3 minutes, and now takes only a
few seconds.

29150:0e9ed09f5fe9

        for op, argsdict in req:
            args = ','.join('%s=%s' % (escapearg(k), escapearg(v))
                            for k, v in argsdict.iteritems())
            cmds.append('%s %s' % (op, args))
        rsp = self._callstream("batch", cmds=';'.join(cmds))
        # TODO this response parsing is probably suboptimal for large
        # batches with large responses.
        work = rsp.read(1024)
        chunk = work
        while chunk:
            while ';' in work:
                one, work = work.split(';', 1)
                yield unescapearg(one)
            chunk = rsp.read(1024)
            work += chunk
        yield unescapearg(work)

    def _submitone(self, op, args):
        return self._call(op, **args)

    def iterbatch(self):

29151:7996c3acc33b

        for op, argsdict in req:
            args = ','.join('%s=%s' % (escapearg(k), escapearg(v))
                            for k, v in argsdict.iteritems())
            cmds.append('%s %s' % (op, args))
        rsp = self._callstream("batch", cmds=';'.join(cmds))
        chunk = rsp.read(1024)
        work = [chunk]
        while chunk:
            while ';' not in chunk and chunk:
                chunk = rsp.read(1024)
                work.append(chunk)
            merged = ''.join(work)
            while ';' in merged:
                one, merged = merged.split(';', 1)
                yield unescapearg(one)
            chunk = rsp.read(1024)
            work = [merged, chunk]
        yield unescapearg(''.join(work))

    def _submitone(self, op, args):
        return self._call(op, **args)

    def iterbatch(self):