comparison rust/hg-cpython/src/parsers.rs @ 42749:7ceded4419a3

rust-dirstate: use EntryState enum instead of literals

This improves code readability quite a bit, while also adding a layer of
safety because we're checking the state byte against the enum.

Differential Revision: https://phab.mercurial-scm.org/D6629

42748:7cae6bc29ff9

    let mut copies = HashMap::new();

    match parse_dirstate(&mut dirstate_map, &mut copies, st.data(py)) {
        Ok(parents) => {
            for (filename, entry) in dirstate_map {
                dmap.set_item(
                    py,
                    PyBytes::new(py, &filename),
                    decapsule_make_dirstate_tuple(py)?(
                        entry.state as c_char,
                        entry.mode,
                        entry.size,
                        entry.mtime,
                    ),
                )?;

                    size,
                    mtime,
                },
            ) in dirstate_map
            {
                dmap.set_item(
                    py,
                    PyBytes::new(py, &filename[..]),
                    decapsule_make_dirstate_tuple(py)?(
                        state as c_char,

42749:7ceded4419a3

    let mut copies = HashMap::new();

    match parse_dirstate(&mut dirstate_map, &mut copies, st.data(py)) {
        Ok(parents) => {
            for (filename, entry) in dirstate_map {
                // Explicitly go through u8 first, then cast to
                // platform-specific `c_char` because Into<u8> has a specific
                // implementation while `as c_char` would just do a naive enum
                // cast.
                let state: u8 = entry.state.into();

                dmap.set_item(
                    py,
                    PyBytes::new(py, &filename),
                    decapsule_make_dirstate_tuple(py)?(
                        state as c_char,
                        entry.mode,
                        entry.size,
                        entry.mtime,
                    ),
                )?;

                    size,
                    mtime,
                },
            ) in dirstate_map
            {
                // Explicitly go through u8 first, then cast to
                // platform-specific `c_char` because Into<u8> has a specific
                // implementation while `as c_char` would just do a naive enum
                // cast.
                let state: u8 = state.into();
                dmap.set_item(
                    py,
                    PyBytes::new(py, &filename[..]),
                    decapsule_make_dirstate_tuple(py)?(
                        state as c_char,