comparison contrib/check-pytype.sh @ 49793:8147abc05794

pytype: stop excluding mercurial/ui.py

ui.extractchoices() is perhaps making assumptions that it shouldn't about the
pattern always matching, but presumably we have test coverage for that.

PyCharm flags the updated classes with a warning "Class xxx must implement all
abstract methods", and suggests adding `abc.ABC` to the superclasses.  I'm not
sure why, unless it doesn't recognize the `__getattr__()` delegation pattern.
Additionally, we can't unconditionally subclass `typing.BinaryIO` because that
defeats the `__getattr__` delegation to the wrapped object at runtime.  Instead,
it has to only subclass during the type checking phase[1].

In any event, this fixes:

    File "/mnt/c/Users/Matt/hg/mercurial/ui.py", line 1518, in _runpager:
        Function subprocess.Popen.__new__ was called with the wrong arguments [wrong-arg-types]
             Expected: (cls, args, bufsize, executable, stdin,
                        stdout: Optional[Union[IO, int]] = ..., ...)
      Actually passed: (cls, args, bufsize, stdin,
                        stdout: Union[mercurial.utils.procutil.WriteAllWrapper,
                                mercurial.windows.winstdout], ...)
    File "/mnt/c/Users/Matt/hg/mercurial/ui.py", line 1798, in extractchoices:
        No attribute 'group' on None [attribute-error]
      In Optional[Match[bytes]]
    File "/mnt/c/Users/Matt/hg/mercurial/ui.py", line 1799, in extractchoices:
        No attribute 'group' on None [attribute-error]
      In Optional[Match[bytes]]

[1] https://stackoverflow.com/q/71365594

49777:e1953a34c110

# mercurial/minirst.py          # [unsupported-operands], [attribute-error]
# mercurial/pure/osutil.py      # [invalid-typevar], [not-callable]
# mercurial/pure/parsers.py     # [attribute-error]
# mercurial/repoview.py         # [attribute-error]
# mercurial/testing/storage.py  # tons of [attribute-error]
# mercurial/ui.py               # [attribute-error], [wrong-arg-types]
# mercurial/unionrepo.py        # ui, svfs, unfiltered [attribute-error]
# mercurial/win32.py            # [not-callable]
# mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
# mercurial/wireprotov1peer.py  # [attribute-error]
# mercurial/wireprotov1server.py  # BUG?: BundleValueError handler accesses subclass's attrs

    -x mercurial/pure/osutil.py \
    -x mercurial/pure/parsers.py \
    -x mercurial/repoview.py \
    -x mercurial/testing/storage.py \
    -x mercurial/thirdparty \
    -x mercurial/ui.py \
    -x mercurial/unionrepo.py \
    -x mercurial/win32.py \
    -x mercurial/wireprotoframing.py \
    -x mercurial/wireprotov1peer.py \
    -x mercurial/wireprotov1server.py

49793:8147abc05794

# mercurial/minirst.py          # [unsupported-operands], [attribute-error]
# mercurial/pure/osutil.py      # [invalid-typevar], [not-callable]
# mercurial/pure/parsers.py     # [attribute-error]
# mercurial/repoview.py         # [attribute-error]
# mercurial/testing/storage.py  # tons of [attribute-error]
# mercurial/unionrepo.py        # ui, svfs, unfiltered [attribute-error]
# mercurial/win32.py            # [not-callable]
# mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
# mercurial/wireprotov1peer.py  # [attribute-error]
# mercurial/wireprotov1server.py  # BUG?: BundleValueError handler accesses subclass's attrs

    -x mercurial/pure/osutil.py \
    -x mercurial/pure/parsers.py \
    -x mercurial/repoview.py \
    -x mercurial/testing/storage.py \
    -x mercurial/thirdparty \
    -x mercurial/unionrepo.py \
    -x mercurial/win32.py \
    -x mercurial/wireprotoframing.py \
    -x mercurial/wireprotov1peer.py \
    -x mercurial/wireprotov1server.py