comparison tests/test-bundle2-exchange.t @ 25485:8182163ae983

push: catch and process PushkeyFailed error

We add a way to register "pushkey failure callback" that will be used if the
push is aborted by a pushkey failure. A part generator adding mandatory pushkey
parts should register a failure callback for all of them. The callback will be
in charge of generating a meaningful abort if this part fails.

If no callback is registered, the error is propagated.

Catch PushkeyFailed error in exchange.

25484:a5192774e925

  $ cat > mandatorypart.py << EOF
  > from mercurial import exchange
  > from mercurial import pushkey
  > from mercurial import node
  > @exchange.b2partsgenerator('failingpuskey')
  > def addfailingpushey(pushop, bundler):
  >     enc = pushkey.encode
  >     part = bundler.newpart('pushkey')
  >     part.addparam('namespace', enc('phases'))
  >     part.addparam('key', enc(pushop.repo['cd010b8cd998'].hex()))
  >     part.addparam('old', enc(str(0))) # successful update
  >     part.addparam('new', enc(str(0)))
  > EOF
  $ cat >> $HGRCPATH << EOF
  > [hooks]
  > pretxnchangegroup=
  > pretxnclose.failpush=

  do not push the key !
  pushkey-abort: prepushkey.failpush hook exited with status 1
  transaction abort!
  Cleaning up the mess...
  rollback completed
  abort: failed to update value for "phases/cd010b8cd998f3981a5a8115f94f8da4ab506089"
  [255]
  $ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6
  pushing to ssh://user@dummy/other
  searching for changes
  remote: adding changesets

  $ cat > mandatorypart.py << EOF
  > from mercurial import exchange
  > from mercurial import pushkey
  > from mercurial import node
  > @exchange.b2partsgenerator('failingpuskey')
  > def addfailingpushey(pushop, bundler):
  >     enc = pushkey.encode
  >     part = bundler.newpart('pushkey')
  >     part.addparam('namespace', enc('phases'))
  >     part.addparam('key', enc(pushop.repo['cd010b8cd998'].hex()))
  >     part.addparam('old', enc(str(4))) # will fail
  >     part.addparam('new', enc(str(3)))
  > EOF
  $ cat >> $HGRCPATH << EOF
  > [hooks]
  > prepushkey.failpush =
  > EOF

  Cleaning up the mess...
  rollback completed
  pushkey: lock state after "phases"
  lock:  free
  wlock: free
  abort: failed to update value for "phases/cd010b8cd998f3981a5a8115f94f8da4ab506089"
  [255]
  $ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6
  pushing to ssh://user@dummy/other
  searching for changes
  remote: adding changesets

25485:8182163ae983

  $ cat > mandatorypart.py << EOF
  > from mercurial import exchange
  > from mercurial import pushkey
  > from mercurial import node
  > from mercurial import error
  > @exchange.b2partsgenerator('failingpuskey')
  > def addfailingpushey(pushop, bundler):
  >     enc = pushkey.encode
  >     part = bundler.newpart('pushkey')
  >     part.addparam('namespace', enc('phases'))
  >     part.addparam('key', enc(pushop.repo['cd010b8cd998'].hex()))
  >     part.addparam('old', enc(str(0))) # successful update
  >     part.addparam('new', enc(str(0)))
  >     def fail(pushop, exc):
  >         raise error.Abort('Correct phase push failed (because hooks)')
  >     pushop.pkfailcb[part.id] = fail
  > EOF
  $ cat >> $HGRCPATH << EOF
  > [hooks]
  > pretxnchangegroup=
  > pretxnclose.failpush=

  do not push the key !
  pushkey-abort: prepushkey.failpush hook exited with status 1
  transaction abort!
  Cleaning up the mess...
  rollback completed
  abort: Correct phase push failed (because hooks)
  [255]
  $ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6
  pushing to ssh://user@dummy/other
  searching for changes
  remote: adding changesets

  $ cat > mandatorypart.py << EOF
  > from mercurial import exchange
  > from mercurial import pushkey
  > from mercurial import node
  > from mercurial import error
  > @exchange.b2partsgenerator('failingpuskey')
  > def addfailingpushey(pushop, bundler):
  >     enc = pushkey.encode
  >     part = bundler.newpart('pushkey')
  >     part.addparam('namespace', enc('phases'))
  >     part.addparam('key', enc(pushop.repo['cd010b8cd998'].hex()))
  >     part.addparam('old', enc(str(4))) # will fail
  >     part.addparam('new', enc(str(3)))
  >     def fail(pushop, exc):
  >         raise error.Abort('Clown phase push failed')
  >     pushop.pkfailcb[part.id] = fail
  > EOF
  $ cat >> $HGRCPATH << EOF
  > [hooks]
  > prepushkey.failpush =
  > EOF

  Cleaning up the mess...
  rollback completed
  pushkey: lock state after "phases"
  lock:  free
  wlock: free
  abort: Clown phase push failed
  [255]
  $ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6
  pushing to ssh://user@dummy/other
  searching for changes
  remote: adding changesets