Mercurial > hg
comparison setup.py @ 49542:8251f7cc787d stable
keepalive: ensure `close_all()` actually closes all cached connections
While debugging why LFS blob downloads are getting corrupted with workers, I
noticed that prior to spinning up the workers, the ConnectionManager has 2
connections to the server and calling `KeepAliveHandler.close_all()` left one
behind. The reason is the value component of `self._cm.get_all().items()` is a
list, and `self._cm.remove()` modifies said list while the caller is iterating
over it. Now `get_all()` is a deep copy of both the dict and lists in all
cases.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Tue, 18 Oct 2022 11:54:58 -0400 |
parents | ece490b02a9b |
children | 54421ef8a423 bc59c1e5dd01 |
comparison
equal
deleted
inserted
replaced
49540:bc2ecf08ae04 | 49542:8251f7cc787d |
---|