comparison hgext/win32mbcs.py @ 29397:844f72885fb9

check-code: detect "missing _() in ui message" more exactly Before this patch, "missing _() in ui message" rule overlooks translatable message, which starts with other than alphabet. To detect "missing _() in ui message" more exactly, this patch improves the regexp with assumptions below. - sequence consisting of below might precede "translatable message" in same string token - formatting string, which starts with '%' - escaped character, which starts with 'b' (as replacement of '\\'), or - characters other than '%', 'b' and 'x' (as replacement of alphabet) - any string tokens might precede a string token, which contains "translatable message" This patch builds an input file, which is used to examine "missing _() in ui message" detection, before '"$check_code" stringjoin.py' in test-contrib-check-code.t, because this reduces amount of change churn in subsequent patch. This patch also applies "()" instead of "_()" on messages below to hide false-positives: - messages for ui.debug() or debug commands/tools - contrib/debugshell.py - hgext/win32mbcs.py (ui.write() is used, though) - mercurial/commands.py - _debugchangegroup - debugindex - debuglocks - debugrevlog - debugrevspec - debugtemplate - untranslatable messages - doc/gendoc.py (ReST specific text) - hgext/hgk.py (permission string) - hgext/keyword.py (text written into configuration file) - mercurial/cmdutil.py (formatting strings for JSON)
author FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
date Tue, 21 Jun 2016 00:50:39 +0900
parents a0939666b836
children d5883fd055c6
comparison
equal deleted inserted replaced
29396:d0ae5b8f80dc 29397:844f72885fb9
190 wrapname(f, reversewrapper) 190 wrapname(f, reversewrapper)
191 # Check sys.args manually instead of using ui.debug() because 191 # Check sys.args manually instead of using ui.debug() because
192 # command line options is not yet applied when 192 # command line options is not yet applied when
193 # extensions.loadall() is called. 193 # extensions.loadall() is called.
194 if '--debug' in sys.argv: 194 if '--debug' in sys.argv:
195 ui.write("[win32mbcs] activated with encoding: %s\n" 195 ui.write(("[win32mbcs] activated with encoding: %s\n")
196 % _encoding) 196 % _encoding)