comparison tests/run-tests.py @ 34040:85bfd6a0bdbf

run-tests: extract prefix of bisect commands to a variable

This does not change any logic.

Differential Revision: https://phab.mercurial-scm.org/D577

34039:72b23c9452d6

            self._runner._checkhglib('Tested')

            savetimes(self._runner._outputdir, result)

            if failed and self._runner.options.known_good_rev:
                def nooutput(args):
                    p = subprocess.Popen(args, stderr=subprocess.STDOUT,
                                         stdout=subprocess.PIPE)
                    p.stdout.read()
                    p.wait()
                for test, msg in result.failures:
                    nooutput(['hg', 'bisect', '--reset']),
                    nooutput(['hg', 'bisect', '--bad', '.'])
                    nooutput(['hg', 'bisect', '--good',
                              self._runner.options.known_good_rev])
                    # TODO: we probably need to forward more options
                    # that alter hg's behavior inside the tests.
                    opts = ''
                    withhg = self._runner.options.with_hg
                    if withhg:
                        opts += ' --with-hg=%s ' % shellquote(withhg)
                    rtc = '%s %s %s %s' % (sys.executable, sys.argv[0], opts,
                                           test)
                    sub = subprocess.Popen(['hg', 'bisect', '--command', rtc],
                                           stderr=subprocess.STDOUT,
                                           stdout=subprocess.PIPE)
                    data = sub.stdout.read()
                    sub.wait()
                    m = re.search(

34040:85bfd6a0bdbf

            self._runner._checkhglib('Tested')

            savetimes(self._runner._outputdir, result)

            if failed and self._runner.options.known_good_rev:
                bisectcmd = ['hg', 'bisect']
                def nooutput(args):
                    p = subprocess.Popen(args, stderr=subprocess.STDOUT,
                                         stdout=subprocess.PIPE)
                    p.stdout.read()
                    p.wait()
                for test, msg in result.failures:
                    nooutput(bisectcmd + ['--reset']),
                    nooutput(bisectcmd + ['--bad', '.'])
                    nooutput(bisectcmd + ['--good',
                              self._runner.options.known_good_rev])
                    # TODO: we probably need to forward more options
                    # that alter hg's behavior inside the tests.
                    opts = ''
                    withhg = self._runner.options.with_hg
                    if withhg:
                        opts += ' --with-hg=%s ' % shellquote(withhg)
                    rtc = '%s %s %s %s' % (sys.executable, sys.argv[0], opts,
                                           test)
                    sub = subprocess.Popen(bisectcmd + ['--command', rtc],
                                           stderr=subprocess.STDOUT,
                                           stdout=subprocess.PIPE)
                    data = sub.stdout.read()
                    sub.wait()
                    m = re.search(