comparison mercurial/cext/revlog.c @ 44500:864e9534d3d4 stable

cext-index: propagate inline_scan error in `index_deref`

Before this change, revlog index corruption could be silently ignored in some
situation.

Differential Revision: https://phab.mercurial-scm.org/D8276

44499:daf083140b5b

		if (self->offsets == NULL) {
			self->offsets = PyMem_Malloc(self->raw_length *
			                             sizeof(*self->offsets));
			if (self->offsets == NULL)
				return (const char *)PyErr_NoMemory();
			inline_scan(self, self->offsets);
		}
		return self->offsets[pos];
	}

	return (const char *)(self->buf.buf) + pos * v1_hdrsize;

44500:864e9534d3d4

		if (self->offsets == NULL) {
			self->offsets = PyMem_Malloc(self->raw_length *
			                             sizeof(*self->offsets));
			if (self->offsets == NULL)
				return (const char *)PyErr_NoMemory();
			Py_ssize_t ret = inline_scan(self, self->offsets);
			if (ret == -1) {
				return NULL;
			};
		}
		return self->offsets[pos];
	}

	return (const char *)(self->buf.buf) + pos * v1_hdrsize;