comparison hgext/rebase.py @ 44053:894c91c2e363

rebase: delete seemingly unnecessary needupdate()

This seemed to be about checking that the user hasn't updated away
when we asked them to resolve merge conflicts. These days we call
`cmdutil.checkunfinished()` and refuse to update, so the user
shouldn't be able to get into this state.

`test-rebase-interruptions.t` actually has some tests where it
disables the rebase extension in order to be allowed to do some of
these updates. That still passes, but I wouldn't personally haved
cared if that failed.

Differential Revision: https://phab.mercurial-scm.org/D7825

44052:b74270da5eee

                updateifonnodes.update(self.destmap.values())
                updateifonnodes.add(self.originalwd)
                shouldupdate = repo[b'.'].rev() in updateifonnodes

                # Update away from the rebase if necessary
                if shouldupdate or needupdate(repo, self.state):
                    mergemod.update(
                        repo, self.originalwd, branchmerge=False, force=True
                    )

                # Strip from the first rebased revision

                        b'either enable obsmarkers to allow unstable '
                        b'revisions or use --keep to keep original '
                        b'changesets'
                    ),
                )
            if needupdate(repo, rbsrt.state):
                # update to the current working revision
                # to clear interrupted merge
                hg.updaterepo(repo, rbsrt.originalwd, overwrite=True)
            rbsrt._finishrebase()
            return 0
    elif inmemory:
        try:
            # in-memory merge doesn't support conflicts, so if we hit any, abort

    if tr:
        tr.removefilegenerator(b'rebasestate')
    repo.vfs.unlinkpath(b"rebasestate", ignoremissing=True)


def needupdate(repo, state):
    '''check whether we should `update --clean` away from a merge, or if
    somehow the working dir got forcibly updated, e.g. by older hg'''
    parents = [p.rev() for p in repo[None].parents()]

    # Are we in a merge state at all?
    if len(parents) < 2:
        return False

    # We should be standing on the first as-of-yet unrebased commit.
    firstunrebased = min(
        [old for old, new in pycompat.iteritems(state) if new == nullrev]
    )
    if firstunrebased in parents:
        return True

    return False


def sortsource(destmap):
    """yield source revisions in an order that we only rebase things once

    If source and destination overlaps, we should filter out revisions
    depending on other revisions which hasn't been rebased yet.

44053:894c91c2e363

                updateifonnodes.update(self.destmap.values())
                updateifonnodes.add(self.originalwd)
                shouldupdate = repo[b'.'].rev() in updateifonnodes

                # Update away from the rebase if necessary
                if shouldupdate:
                    mergemod.update(
                        repo, self.originalwd, branchmerge=False, force=True
                    )

                # Strip from the first rebased revision

                        b'either enable obsmarkers to allow unstable '
                        b'revisions or use --keep to keep original '
                        b'changesets'
                    ),
                )
            # update to the current working revision
            # to clear interrupted merge
            hg.updaterepo(repo, rbsrt.originalwd, overwrite=True)
            rbsrt._finishrebase()
            return 0
    elif inmemory:
        try:
            # in-memory merge doesn't support conflicts, so if we hit any, abort

    if tr:
        tr.removefilegenerator(b'rebasestate')
    repo.vfs.unlinkpath(b"rebasestate", ignoremissing=True)


def sortsource(destmap):
    """yield source revisions in an order that we only rebase things once

    If source and destination overlaps, we should filter out revisions
    depending on other revisions which hasn't been rebased yet.