comparison mercurial/wireprotov2server.py @ 37722:89a16704114c

wireprotov2: define response data as CBOR

Previously, response data was defined as a stream of bytes. We had
the option to declare it as CBOR using a frame flag.

We've converged all wire protocol commands exposed on version 2 to
CBOR. I think consistency is important. The overhead to encoding
things with CBOR is minimal. Even a very large bytestring can be
efficiently encoded using an indefinite length bytestring. Now,
there are limitations with consumers not being able to efficiently
stream large CBOR values. But these feel like solvable problems.

This commit removes the "is CBOR" frame flag from command response
frames and defines the frame as always consisting of a stream of
CBOR values.

The framing protocol media type has been bumped to reflect this
BC change.

Differential Revision: https://phab.mercurial-scm.org/D3382

37721:f7673845b167

    wireproto,
    wireprotoframing,
    wireprototypes,
)

FRAMINGTYPE = b'application/mercurial-exp-framing-0003'

HTTP_WIREPROTO_V2 = wireprototypes.HTTP_WIREPROTO_V2

def handlehttpv2request(rctx, req, res, checkperm, urlparts):
    from .hgweb import common as hgwebcommon

                                                    rsp.data)
    elif isinstance(rsp, wireprototypes.cborresponse):
        encoded = cbor.dumps(rsp.value, canonical=True)
        action, meta = reactor.onbytesresponseready(outstream,
                                                    command['requestid'],
                                                    encoded,
                                                    iscbor=True)
    else:
        action, meta = reactor.onapplicationerror(
            _('unhandled response type from wire proto command'))

    if action == 'sendframes':

37722:89a16704114c

    wireproto,
    wireprotoframing,
    wireprototypes,
)

FRAMINGTYPE = b'application/mercurial-exp-framing-0004'

HTTP_WIREPROTO_V2 = wireprototypes.HTTP_WIREPROTO_V2

def handlehttpv2request(rctx, req, res, checkperm, urlparts):
    from .hgweb import common as hgwebcommon

                                                    rsp.data)
    elif isinstance(rsp, wireprototypes.cborresponse):
        encoded = cbor.dumps(rsp.value, canonical=True)
        action, meta = reactor.onbytesresponseready(outstream,
                                                    command['requestid'],
                                                    encoded)
    else:
        action, meta = reactor.onapplicationerror(
            _('unhandled response type from wire proto command'))

    if action == 'sendframes':