comparison mercurial/match.py @ 43965:8a81fa44f7bb

match: don't util.normpath() cwd The problem here is that `util.normpath()` calls `util.pconvert()`, which switches to Unix style separators. That results in two test failures like this since 5685ce2ea3bf: --- c:/Users/Matt/hg/tests/test-globalopts.t +++ c:/Users/Matt/hg/tests/test-globalopts.t.err @@ -89,7 +89,7 @@ [255] $ hg -R b ann a/a abort: a/a not under root '$TESTTMP/b' - (consider using '--cwd b') + (consider using '--cwd ..\$TESTTMP\b') [255] $ hg log abort: no repository found in '$TESTTMP' (.hg not found)! ERROR: test-globalopts.t output changed Martin originally had `os.path.normpath()` (which *would* work here too), but changed it during review. He didn't remember why he thought any form is needed here. Most uses simply pass '' or `repo.getcwd()`, so these should generally be in local format anyway. It seems better if `cwd` and `root` use consistent styles here. Differential Revision: https://phab.mercurial-scm.org/D7725
author Matt Harbison <matt_harbison@yahoo.com>
date Thu, 26 Dec 2019 18:26:06 -0500
parents 8f67735344ae
children d9d78e70149a
comparison
equal deleted inserted replaced
43964:8f67735344ae 43965:8a81fa44f7bb
230 True 230 True
231 >>> m.exact(b'main.c') 231 >>> m.exact(b'main.c')
232 False 232 False
233 """ 233 """
234 assert os.path.isabs(root) 234 assert os.path.isabs(root)
235 cwd = util.normpath(os.path.join(root, cwd)) 235 cwd = os.path.join(root, util.localpath(cwd))
236 normalize = _donormalize 236 normalize = _donormalize
237 if icasefs: 237 if icasefs:
238 dirstate = ctx.repo().dirstate 238 dirstate = ctx.repo().dirstate
239 dsnormalize = dirstate.normalize 239 dsnormalize = dirstate.normalize
240 240