Mercurial > hg
comparison tests/test-static-http.t @ 33604:8b00c723cee1 stable
statichttprepo: implement wlock() (issue5613)
statichttprepo inherits from localrepository. In doing so, it
obtains default implementations of various methods, like wlock().
Before this change, tags cache writing would call repo.wlock().
This failed on statichttprepo due to localrepository's wlock()
looking for an instance attribute that doesn't exist on statichttprepo
(statichttprepo doesn't call localrepository.__init__).
We /could/ define missing attributes until the base wlock() works.
However, a statichttprepo is remote and read-only and can't be
locked. The class already has a lock() that short circuits. So
it makes sense to implement a short-circuited wlock() as well. That
is what this patch does.
LockError is expected to be raised when locking fails. The constructor
takes a number of arguments that are local repository centric. Rather
than rework LockError to not require them (which would not be
appropriate for stable), this commit populates dummy values. I don't
believe they'll ever be seen by the user, as lock failures on
static http repos should be limited to well-defined (and tested)
scenarios. We can and should revisit the LockError type to improve
this.
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Sat, 29 Jul 2017 12:50:56 -0700 |
| parents | 075823a6161b |
| children | eb586ed5d8ce |
comparison
equal
deleted
inserted
replaced
| 33603:075823a6161b | 33604:8b00c723cee1 |
|---|---|
| 185 updating to branch default | 185 updating to branch default |
| 186 1 files updated, 0 files merged, 0 files removed, 0 files unresolved | 186 1 files updated, 0 files merged, 0 files removed, 0 files unresolved |
| 187 | 187 |
| 188 Clone a specific branch works | 188 Clone a specific branch works |
| 189 | 189 |
| 190 $ hg clone -r mybranch static-http://localhost:$HGPORT/remote-with-names local-with-names-branch 2> /dev/null | 190 $ hg clone -r mybranch static-http://localhost:$HGPORT/remote-with-names local-with-names-branch |
| 191 [1] | 191 adding changesets |
| 192 adding manifests | |
| 193 adding file changes | |
| 194 added 4 changesets with 4 changes to 2 files | |
| 195 updating to branch mybranch | |
| 196 2 files updated, 0 files merged, 0 files removed, 0 files unresolved | |
| 192 | 197 |
| 193 Clone a specific tag works | 198 Clone a specific tag works |
| 194 | 199 |
| 195 $ hg clone -r default-tag static-http://localhost:$HGPORT/remote-with-names local-with-names-tag 2> /dev/null | 200 $ hg clone -r default-tag static-http://localhost:$HGPORT/remote-with-names local-with-names-tag |
| 196 [1] | 201 adding changesets |
| 202 adding manifests | |
| 203 adding file changes | |
| 204 added 2 changesets with 2 changes to 1 files | |
| 205 updating to branch default | |
| 206 1 files updated, 0 files merged, 0 files removed, 0 files unresolved | |
| 197 | 207 |
| 198 $ killdaemons.py | 208 $ killdaemons.py |