comparison tests/simplestorerepo.py @ 40047:8e398628a3f2

repository: define and use revision flag constants Revlogs have a per-revision 2 byte field holding integer flags that define how revision data should be interpreted. For historical reasons, these integer values are sent verbatim on the wire protocol as part of changegroup data. From a semantic standpoint, the flags that go out over the wire are different from the flags stored internally by revlogs. Failure to establish this semantic distinction creates unwanted strong coupling between revlog's internals and the wire protocol. This commit establishes new constants on the repository module that define the revision flags used by the wire protocol (and by some internal storage APIs, sadly). The changegroups internals documentation has been updated to document them explicitly. Various references throughout the repo now use the repository constants instead of the revlog constants. This is done to make it clear that we're operating on generic revision data and this isn't tied to revlogs. Differential Revision: https://phab.mercurial-scm.org/D4860
author Gregory Szorc <gregory.szorc@gmail.com>
date Wed, 03 Oct 2018 12:57:01 -0700
parents 2f80eaf38ed4
children 1b183edbb68e
comparison
equal deleted inserted replaced
40046:50700a025953 40047:8e398628a3f2
369 return len(self.revision(node)) 369 return len(self.revision(node))
370 370
371 def iscensored(self, rev): 371 def iscensored(self, rev):
372 validaterev(rev) 372 validaterev(rev)
373 373
374 return self._flags(rev) & revlog.REVIDX_ISCENSORED 374 return self._flags(rev) & repository.REVISION_FLAG_CENSORED
375 375
376 def commonancestorsheads(self, a, b): 376 def commonancestorsheads(self, a, b):
377 validatenode(a) 377 validatenode(a)
378 validatenode(b) 378 validatenode(b)
379 379