comparison mercurial/commands.py @ 17126:8fa8717b47b6

obsolete: write obsolete marker inside a transaction

Marker are now written as soon as possible but within a transaction. Using a
transaction ensure a proper behavior on error and rollback compatibility.

Flush logic are not necessary anymore and are dropped from lock release.

With this changeset, the obsstore is open, written and closed for every single
added marker. This is expected to be highly inefficient and batched write should
be implemented "quickly".

Another issue is that every flush of the file will invalidate the obsstore
filecache and trigger a full re instantiation of the repo.obsstore attribute
(including, reading and parsing entry). This is also expected to be highly
inefficient and proper filecache operation should be implemented "quickly" too.

A side benefit of the filecache issue is that repo.obsstore  object is properly
invalidated on transaction abortion.

17125:95d785ccb4e5

            metadata['date'] = opts['date']
        metadata['user'] = opts['user'] or ui.username()
        succs = tuple(bin(succ) for succ in successors)
        l = repo.lock()
        try:
            repo.obsstore.create(bin(precursor), succs, 0, metadata)
        finally:
            l.release()
    else:
        for m in obsolete.allmarkers(repo):
            ui.write(hex(m.precnode()))

17126:8fa8717b47b6

            metadata['date'] = opts['date']
        metadata['user'] = opts['user'] or ui.username()
        succs = tuple(bin(succ) for succ in successors)
        l = repo.lock()
        try:
            tr = repo.transaction('debugobsolete')
            try:
                repo.obsstore.create(tr, bin(precursor), succs, 0, metadata)
                tr.close()
            finally:
                tr.release()
        finally:
            l.release()
    else:
        for m in obsolete.allmarkers(repo):
            ui.write(hex(m.precnode()))