comparison mercurial/localrepo.py @ 17126:8fa8717b47b6

obsolete: write obsolete marker inside a transaction

Marker are now written as soon as possible but within a transaction. Using a
transaction ensure a proper behavior on error and rollback compatibility.

Flush logic are not necessary anymore and are dropped from lock release.

With this changeset, the obsstore is open, written and closed for every single
added marker. This is expected to be highly inefficient and batched write should
be implemented "quickly".

Another issue is that every flush of the file will invalidate the obsstore
filecache and trigger a full re instantiation of the repo.obsstore attribute
(including, reading and parsing entry). This is also expected to be highly
inefficient and proper filecache operation should be implemented "quickly" too.

A side benefit of the filecache issue is that repo.obsstore  object is properly
invalidated on transaction abortion.

17125:95d785ccb4e5

        def unlock():
            self.store.write()
            if '_phasecache' in vars(self):
                self._phasecache.write()
            if 'obsstore' in vars(self):
                self.obsstore.flushmarkers()
            for k, ce in self._filecache.items():
                if k == 'dirstate':
                    continue
                ce.refresh()

            r.append(l)

        return r

    def pull(self, remote, heads=None, force=False):
        lock = self.lock()
        try:
            tmp = discovery.findcommonincoming(self, remote, heads=heads,
                                               force=force)
            common, fetch, rheads = tmp
            if not fetch:
                self.ui.status(_("no changes found\n"))
                added = []
                result = 0
            else:
                if heads is None and list(common) == [nullid]:
                    self.ui.status(_("requesting all changes\n"))
                elif heads is None and remote.capable('changegroupsubset'):
                    # issue1320, avoid a race if remote changed after discovery
                    heads = rheads

                # should be seen as public
                phases.advanceboundary(self, phases.public, subset)

            remoteobs = remote.listkeys('obsolete')
            if 'dump' in remoteobs:
                data = base85.b85decode(remoteobs['dump'])
                self.obsstore.mergemarkers(data)
        finally:
            lock.release()

        return result

    def checkpush(self, force, revs):

17126:8fa8717b47b6

        def unlock():
            self.store.write()
            if '_phasecache' in vars(self):
                self._phasecache.write()
            for k, ce in self._filecache.items():
                if k == 'dirstate':
                    continue
                ce.refresh()

            r.append(l)

        return r

    def pull(self, remote, heads=None, force=False):
        # don't open transaction for nothing or you break future useful
        # rollback call
        tr = None
        trname = 'pull\n' + util.hidepassword(remote.url())
        lock = self.lock()
        try:
            tmp = discovery.findcommonincoming(self, remote, heads=heads,
                                               force=force)
            common, fetch, rheads = tmp
            if not fetch:
                self.ui.status(_("no changes found\n"))
                added = []
                result = 0
            else:
                tr = self.transaction(trname)
                if heads is None and list(common) == [nullid]:
                    self.ui.status(_("requesting all changes\n"))
                elif heads is None and remote.capable('changegroupsubset'):
                    # issue1320, avoid a race if remote changed after discovery
                    heads = rheads

                # should be seen as public
                phases.advanceboundary(self, phases.public, subset)

            remoteobs = remote.listkeys('obsolete')
            if 'dump' in remoteobs:
                if tr is None:
                    tr = self.transaction(trname)
                data = base85.b85decode(remoteobs['dump'])
                self.obsstore.mergemarkers(tr, data)
            if tr is not None:
                tr.close()
        finally:
            if tr is not None:
                tr.release()
            lock.release()

        return result

    def checkpush(self, force, revs):