comparison i18n/posplit @ 39312:9198e41df6ef

localrepo: do not cache auditor/nofsauditor which would make reference cycle Before, self.auditor and self.nofsauditor held self through self._checknested, and the following code couldn't free a repo by ref-counting. def main(): repo = localrepo.localrepository(uimod.ui(), '../testrepos/hello') main() With this change, the cache of the nofsauditor is limited to a single match session. I think that's okay as the nofsauditor doesn't do any filesystem access. Alternatively, maybe we can remove the callback from nofsauditor since it isn't used unless realfs=True, but I have no idea whether it is a bug or not.
author Yuya Nishihara <yuya@tcha.org>
date Wed, 22 Aug 2018 20:52:36 +0900
parents d0e8933d6dad
children aaad36b88298
comparison
equal deleted inserted replaced
39311:57f9b3d91abc 39312:9198e41df6ef