comparison contrib/chg/chg.c @ 45850:9534de20358f stable

chg: do not close dir fd while iterating

It works so long as the dp is the last entry, but readdir(dp) would fail
with EBADF. Let's not do that and close the dir fd explicitly.

45849:731ea8fa1f11

				debugmsg("tried to parse %s, but range error "
				         "occurred",
				         de->d_name);
				continue;
			}
			if (fd_value > STDERR_FILENO) {
				debugmsg("closing fd %ld", fd_value);
				int res = close(fd_value);
				if (res) {
					debugmsg("tried to close fd %ld: %d "
					         "(errno: %d)",
					         fd_value, res, errno);
				}
			}
		}
	}

	if (putenv("CHGINTERNALMARK=") != 0)
		abortmsgerrno("failed to putenv");
	if (execvp(hgcmd, (char **)argv) < 0)

45850:9534de20358f

				debugmsg("tried to parse %s, but range error "
				         "occurred",
				         de->d_name);
				continue;
			}
			if (fd_value > STDERR_FILENO && fd_value != dirfd(dp)) {
				debugmsg("closing fd %ld", fd_value);
				int res = close(fd_value);
				if (res) {
					debugmsg("tried to close fd %ld: %d "
					         "(errno: %d)",
					         fd_value, res, errno);
				}
			}
		}
		closedir(dp);
	}

	if (putenv("CHGINTERNALMARK=") != 0)
		abortmsgerrno("failed to putenv");
	if (execvp(hgcmd, (char **)argv) < 0)