Mercurial > hg
comparison hgext/histedit.py @ 37505:966061b8826d
histedit: drop unnecessary check for "self.node is not None"
We are doing hex(self.node) just a few lines up, so it shouldn't be
None. The only way it could be none is if it was reassigned in
between. The only way that can happen is if the user had put a
"ffff..." wdirhex revision in the histedit script. This code is much
older than the "ffff..." identifier, so I'm confident it's not there
to handle that case. I'll let someone else add proper checks for
"ffff..." if they care enough.
Differential Revision: https://phab.mercurial-scm.org/D3157
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Fri, 06 Apr 2018 09:41:25 -0700 |
parents | 8474005fcfe2 |
children | c4131138eadb |
comparison
equal
deleted
inserted
replaced
37504:901e749ca0e1 | 37505:966061b8826d |
---|---|
446 try: | 446 try: |
447 self.node = repo[ha].node() | 447 self.node = repo[ha].node() |
448 except error.RepoError: | 448 except error.RepoError: |
449 raise error.ParseError(_('unknown changeset %s listed') | 449 raise error.ParseError(_('unknown changeset %s listed') |
450 % ha[:12]) | 450 % ha[:12]) |
451 if self.node is not None: | 451 self._verifynodeconstraints(prev, expected, seen) |
452 self._verifynodeconstraints(prev, expected, seen) | |
453 | 452 |
454 def _verifynodeconstraints(self, prev, expected, seen): | 453 def _verifynodeconstraints(self, prev, expected, seen): |
455 # by default command need a node in the edited list | 454 # by default command need a node in the edited list |
456 if self.node not in expected: | 455 if self.node not in expected: |
457 raise error.ParseError(_('%s "%s" changeset was not a candidate') | 456 raise error.ParseError(_('%s "%s" changeset was not a candidate') |