comparison mercurial/hgweb/webcommands.py @ 30816:96f811bceb85

hgweb: build the "entries" list directly in filelog command

There's no apparent reason to have this "entries" generator function that
builds a list and then yields its elements in reverse order and which is only
called to build the "entries" list. So just build the list directly, in
reverse order.

Adjust "parity" generator's offset to keep rendering the same.

30815:c5bf2e8ec18c

    morevars['revcount'] = revcount * 2

    count = fctx.filerev() + 1
    start = max(0, fctx.filerev() - revcount + 1) # first rev on this page
    end = min(count, start + revcount) # last rev on this page
    parity = paritygen(web.stripecount, offset=start - end)

    def entries():
        l = []

        repo = web.repo
        revs = fctx.filelog().revs(start, end - 1)
        for i in revs:
            iterfctx = fctx.filectx(i)

            l.append(dict(
                parity=next(parity),
                filerev=i,
                file=f,
                rename=webutil.renamelink(iterfctx),
                **webutil.commonentry(repo, iterfctx)))
        for e in reversed(l):
            yield e

    entries = list(entries())
    latestentry = entries[:1]

    revnav = webutil.filerevnav(web.repo, fctx.path())
    nav = revnav.gen(end - 1, revcount, count)
    return tmpl("filelog",

30816:96f811bceb85

    morevars['revcount'] = revcount * 2

    count = fctx.filerev() + 1
    start = max(0, fctx.filerev() - revcount + 1) # first rev on this page
    end = min(count, start + revcount) # last rev on this page
    parity = paritygen(web.stripecount, offset=start - end + 1)

    repo = web.repo
    revs = fctx.filelog().revs(start, end - 1)
    entries = []
    for i in reversed(revs):
        iterfctx = fctx.filectx(i)
        entries.append(dict(
            parity=next(parity),
            filerev=i,
            file=f,
            rename=webutil.renamelink(iterfctx),
            **webutil.commonentry(repo, iterfctx)))

    latestentry = entries[:1]

    revnav = webutil.filerevnav(web.repo, fctx.path())
    nav = revnav.gen(end - 1, revcount, count)
    return tmpl("filelog",