comparison tests/test-check-interfaces.py @ 39842:97986c9c69d3

verify: start to abstract file verification

Currently, the file storage interface has a handful of attributes
that are exclusively or near-exclusively used by repo verification
code. In order to support verification on non-revlog/alternate
storage backends, we'll need to abstract verification so it can
be performed in a storage-agnostic way.

This commit starts that process.

We establish a new verifyintegrity() method on revlogs and expose
it to the file storage interface. Most of verify.verifier.checklog()
has been ported to this new method.

We need a way to represent verification problems. So we invent an
interface to represent a verification problem, invent a revlog type
to implement that interface, and use it.

The arguments to verifyintegrity() will almost certainly change in
the future, once more functionality is ported from the verify code.
And the "revlogv1" version check is very hacky. (The code in verify
is actually buggy because it is comparing the full 32-bit header
integer instead of just the revlog version short. I'll likely fix
this in a subsequent commit.)

Differential Revision: https://phab.mercurial-scm.org/D4701

39841:39f51064e9f5

        p1node=b'',
        p2node=b'',
        basenode=b'')
    checkzobject(rdr)

main()

39842:97986c9c69d3

        p1node=b'',
        p2node=b'',
        basenode=b'')
    checkzobject(rdr)

    ziverify.verifyClass(repository.iverifyproblem,
                         revlog.revlogproblem)
    checkzobject(revlog.revlogproblem())

main()