comparison hgext/blackbox.py @ 33436:9bb4decd43b0

repovfs: add a ward to check if locks are properly taken When the appropriate developer warnings are enabled, We wrap 'repo.vfs.audit' to check for locks when accessing file in '.hg' for writing. Another changeset will add a 'ward' for the store vfs (svfs). This check system has caught a handful of locking issues that have been fixed in previous series (mostly in 4.0). I expect another batch to be caught in third party extensions. We introduce two real exceptions from extensions 'blackbox.log' (because a lot of read-only operations add entry to it), and 'last-email.txt' (because 'hg email' is currently a read only operation and there is value to keep it this way). In addition we are currently allowing bisect to operate outside of the lock because the current code is a bit hard to get properly locked for now. Multiple clean up have been made but there is still a couple of them to do and the freeze is coming.
author Boris Feld <boris.feld@octobus.net>
date Tue, 11 Jul 2017 12:38:17 +0200
parents 66fe60d5f291
children 4f60720cf0df
comparison
equal deleted inserted replaced
33435:456626e9c3d1 33436:9bb4decd43b0
232 if not repo.local(): 232 if not repo.local():
233 return 233 return
234 234
235 if util.safehasattr(ui, 'setrepo'): 235 if util.safehasattr(ui, 'setrepo'):
236 ui.setrepo(repo) 236 ui.setrepo(repo)
237 repo._wlockfreeprefix.add('blackbox.log')
237 238
238 @command('^blackbox', 239 @command('^blackbox',
239 [('l', 'limit', 10, _('the number of events to show')), 240 [('l', 'limit', 10, _('the number of events to show')),
240 ], 241 ],
241 _('hg blackbox [OPTION]...')) 242 _('hg blackbox [OPTION]...'))