comparison mercurial/obsutil.py @ 51502:a5d8f261b716 stable

obsutil: sort metadata before comparing in geteffectflag()

This is probably less important now that we dropped Python 2. We do still
support Python 3.6 though, and the dictionaries aren't ordered there either
(that was a big change that came with 3.7).

Still, maybe it's a good idea to sort metadata explicitly.

51501:e5b28637f4ca

        if changectx.parents() != source.parents():
            effects |= PARENTCHANGED

        # Check if other meta has changed
        changeextra = changectx.extra().items()
        ctxmeta = list(filter(metanotblacklisted, changeextra))

        sourceextra = source.extra().items()
        srcmeta = list(filter(metanotblacklisted, sourceextra))

        if ctxmeta != srcmeta:
            effects |= METACHANGED

        # Check if the diff has changed

51502:a5d8f261b716

        if changectx.parents() != source.parents():
            effects |= PARENTCHANGED

        # Check if other meta has changed
        changeextra = changectx.extra().items()
        ctxmeta = sorted(filter(metanotblacklisted, changeextra))

        sourceextra = source.extra().items()
        srcmeta = sorted(filter(metanotblacklisted, sourceextra))

        if ctxmeta != srcmeta:
            effects |= METACHANGED

        # Check if the diff has changed