Mercurial > hg
comparison mercurial/filelog.py @ 39778:a6b3c4c1019f
revlog: move censor logic out of censor extension
The censor extension is doing very low-level things with revlogs.
It is fundamentally impossible for this logic to remain in the censor
extension while support multiple storage backends: we need each
storage backend to implement censor in its own storage-specific
way.
This commit effectively moves the revlog-specific censoring code to
be a method of revlogs themselves.
We've defined a new API on the file storage interface for censoring
an individual node. Even though the current censoring code doesn't
use it, the API requires a transaction instance because it logically
makes sense for storage backends to require an active transaction
(which implies a held write lock) in order to rewrite storage.
After this commit, the censor extension has been reduced to
boilerplate precondition checking before invoking the generic
storage API.
I tried to keep the code as similar as possible. But some minor
changes were made:
* We use self._io instead of instantiating a new revlogio instance.
* We compare self.version against REVLOGV0 instead of != REVLOGV1
because presumably all future revlog versions will support censoring.
* We use self.opener instead of going through repo.svfs (we don't have
a handle on the repo instance from a revlog).
* "revlog" dropped
* Replace "flog" with "self".
Differential Revision: https://phab.mercurial-scm.org/D4656
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 18 Sep 2018 17:51:43 -0700 |
parents | 3e801ffd7269 |
children | 42aa61fc5544 |
comparison
equal
deleted
inserted
replaced
39777:b63dee7bd0d9 | 39778:a6b3c4c1019f |
---|---|
108 def getstrippoint(self, minlink): | 108 def getstrippoint(self, minlink): |
109 return self._revlog.getstrippoint(minlink) | 109 return self._revlog.getstrippoint(minlink) |
110 | 110 |
111 def strip(self, minlink, transaction): | 111 def strip(self, minlink, transaction): |
112 return self._revlog.strip(minlink, transaction) | 112 return self._revlog.strip(minlink, transaction) |
113 | |
114 def censorrevision(self, tr, node, tombstone=b''): | |
115 return self._revlog.censorrevision(node, tombstone=tombstone) | |
113 | 116 |
114 def files(self): | 117 def files(self): |
115 return self._revlog.files() | 118 return self._revlog.files() |
116 | 119 |
117 def checksize(self): | 120 def checksize(self): |