comparison mercurial/url.py @ 37045:a708e1e4d7a8

url: support suppressing Accept header

Sending this header automatically could interfere with future
testing and client behavior. Let's add a knob to disable the
behavior.

We don't have a control for User-Agent because urllib will send
it if we don't set something. I don't feel like hacking into the
bowels of urllib to figure out how to suppress that. UA shouldn't
be used for anything meaningful. So it shouldn't pose any problems
beyond non-determinism (since the header has the Mercurial version in
it).

Differential Revision: https://phab.mercurial-scm.org/D2843

37044:d3a9036d9ae9

        return request

handlerfuncs = []

def opener(ui, authinfo=None, useragent=None, loggingfh=None,
           loggingname=b's', loggingopts=None):
    '''
    construct an opener suitable for urllib2
    authinfo will be added to the password manager

    The opener can be configured to log socket events if the various

    ``loggingfh`` denotes a file object to log events to.
    ``loggingname`` denotes the name of the to print when logging.
    ``loggingopts`` is a dict of keyword arguments to pass to the constructed
    ``util.socketobserver`` instance.
    '''
    handlers = []

    if loggingfh:
        handlers.append(logginghttphandler(loggingfh, loggingname,

    # This header should only be needed by wire protocol requests. But it has
    # been sent on all requests since forever. We keep sending it for backwards
    # compatibility reasons. Modern versions of the wire protocol use
    # X-HgProto-<N> for advertising client support.
    opener.addheaders.append((r'Accept', r'application/mercurial-0.1'))
    return opener

def open(ui, url_, data=None):
    u = util.url(url_)
    if u.scheme:

37045:a708e1e4d7a8

        return request

handlerfuncs = []

def opener(ui, authinfo=None, useragent=None, loggingfh=None,
           loggingname=b's', loggingopts=None, sendaccept=True):
    '''
    construct an opener suitable for urllib2
    authinfo will be added to the password manager

    The opener can be configured to log socket events if the various

    ``loggingfh`` denotes a file object to log events to.
    ``loggingname`` denotes the name of the to print when logging.
    ``loggingopts`` is a dict of keyword arguments to pass to the constructed
    ``util.socketobserver`` instance.

    ``sendaccept`` allows controlling whether the ``Accept`` request header
    is sent. The header is sent by default.
    '''
    handlers = []

    if loggingfh:
        handlers.append(logginghttphandler(loggingfh, loggingname,

    # This header should only be needed by wire protocol requests. But it has
    # been sent on all requests since forever. We keep sending it for backwards
    # compatibility reasons. Modern versions of the wire protocol use
    # X-HgProto-<N> for advertising client support.
    if sendaccept:
        opener.addheaders.append((r'Accept', r'application/mercurial-0.1'))

    return opener

def open(ui, url_, data=None):
    u = util.url(url_)
    if u.scheme: