Mercurial > hg
comparison tests/test-http-api-httpv2.t @ 40048:a732d70253b0
tests: don't be as verbose in wireprotov2 tests
I don't think that printing low-level I/O and frames is beneficial to
testing command-level functionality. Protocol-level testing, yes. But
command-level functionality shouldn't care about low-level details in
most cases. This output makes tests more verbose and harder to read.
It also makes them harder to maintain, as you need to glob over various
dynamic width fields.
Let's remove these low-level details from many of the wireprotov2
tests.
Differential Revision: https://phab.mercurial-scm.org/D4861
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Wed, 03 Oct 2018 09:48:22 -0700 |
| parents | 393e44324037 |
| children | 762ef19a07e3 |
comparison
equal
deleted
inserted
replaced
| 40047:8e398628a3f2 | 40048:a732d70253b0 |
|---|---|
| 186 s> \x00\x00\x00\x01\x00\x02\x002 | 186 s> \x00\x00\x00\x01\x00\x02\x002 |
| 187 s> \r\n | 187 s> \r\n |
| 188 s> 0\r\n | 188 s> 0\r\n |
| 189 s> \r\n | 189 s> \r\n |
| 190 | 190 |
| 191 $ sendhttpv2peer << EOF | 191 $ sendhttpv2peerverbose << EOF |
| 192 > command customreadonly | 192 > command customreadonly |
| 193 > EOF | 193 > EOF |
| 194 creating http peer for wire protocol version 2 | 194 creating http peer for wire protocol version 2 |
| 195 sending customreadonly command | 195 sending customreadonly command |
| 196 s> POST /api/exp-http-v2-0002/ro/customreadonly HTTP/1.1\r\n | 196 s> POST /api/exp-http-v2-0002/ro/customreadonly HTTP/1.1\r\n |