Mercurial > hg
comparison mercurial/manifest.py @ 39241:aad4b46e89bb
manifest: remove addgroup() from manifestlog and imanifestlog
addgroup() is part of the storage interface for manifests.
Unfortunately, we don't yet have a formal storage interface
for manifests. (One will be established in subsequent commits.)
One thing is for sure, addgroup() doesn't belong on imanifestlog -
at least not unless we extend that interface to encompass storage.
For now, let's access addgroup() on the _revlog attribute, just like
we do for tree manifests. Even though this violates visibility,
it is consistent.
Differential Revision: https://phab.mercurial-scm.org/D4274
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Fri, 10 Aug 2018 14:20:47 -0700 |
parents | 43387fd2aa1f |
children | 1347bcf52d51 |
comparison
equal
deleted
inserted
replaced
39240:2af6b2d8d1d8 | 39241:aad4b46e89bb |
---|---|
1483 self._revlog.clearcaches(clear_persisted_data=clear_persisted_data) | 1483 self._revlog.clearcaches(clear_persisted_data=clear_persisted_data) |
1484 | 1484 |
1485 def rev(self, node): | 1485 def rev(self, node): |
1486 return self._revlog.rev(node) | 1486 return self._revlog.rev(node) |
1487 | 1487 |
1488 def addgroup(self, deltas, linkmapper, transaction): | |
1489 return self._revlog.addgroup(deltas, linkmapper, transaction) | |
1490 | |
1491 @interfaceutil.implementer(repository.imanifestrevisionwritable) | 1488 @interfaceutil.implementer(repository.imanifestrevisionwritable) |
1492 class memmanifestctx(object): | 1489 class memmanifestctx(object): |
1493 def __init__(self, manifestlog): | 1490 def __init__(self, manifestlog): |
1494 self._manifestlog = manifestlog | 1491 self._manifestlog = manifestlog |
1495 self._manifestdict = manifestdict() | 1492 self._manifestdict = manifestdict() |