comparison mercurial/changegroup.py @ 13456:ab3f4ee48adc stable

changegroup: don't accept streams without proper termination

Streams should be terminated with a zero size changegroup, and read should
never be permitted to return less than requested.

13455:053c042118bc

import struct, os, bz2, zlib, tempfile

def getchunk(source):
    """return the next chunk from changegroup 'source' as a string"""
    d = source.read(4)
    if not d:
        return ""
    l = struct.unpack(">l", d)[0]
    if l <= 4:
        return ""
    d = source.read(l - 4)
    if len(d) < l - 4:

    def close(self):
        return self._stream.close()

    def chunklength(self):
        d = self.read(4)
        if not d:
            return 0
        l = max(0, struct.unpack(">l", d)[0] - 4)
        if l and self.callback:
            self.callback()
        return l

13456:ab3f4ee48adc

import struct, os, bz2, zlib, tempfile

def getchunk(source):
    """return the next chunk from changegroup 'source' as a string"""
    d = source.read(4)
    l = struct.unpack(">l", d)[0]
    if l <= 4:
        return ""
    d = source.read(l - 4)
    if len(d) < l - 4:

    def close(self):
        return self._stream.close()

    def chunklength(self):
        d = self.read(4)
        l = max(0, struct.unpack(">l", d)[0] - 4)
        if l and self.callback:
            self.callback()
        return l