comparison mercurial/util.py @ 41384:b141b5243b37

util: cast memoryview to bytes

Python 3 uses readinto() instead of read() in places. And
taking a slice of the buffer passed to readinto() will produce
a memoryview. _writedata() then gets confused when testing for
`b'\n' in data` because memoryview is an iterable over ints
instead of 1 character bytes.

We work around by casting a memoryview to bytes.

Differential Revision: https://phab.mercurial-scm.org/D5704

41383:0cfbe78fc13e

        if self.logdataapis:
            self.fh.write('%s> readinto(%d) -> %r' % (self.name, len(dest),
                                                      res))

        data = dest[0:res] if res is not None else b''
        self._writedata(data)

    def write(self, res, data):
        if not self.writes:
            return

41384:b141b5243b37

        if self.logdataapis:
            self.fh.write('%s> readinto(%d) -> %r' % (self.name, len(dest),
                                                      res))

        data = dest[0:res] if res is not None else b''

        # _writedata() uses "in" operator and is confused by memoryview because
        # characters are ints on Python 3.
        if isinstance(data, memoryview):
            data = data.tobytes()

        self._writedata(data)

    def write(self, res, data):
        if not self.writes:
            return