comparison hgext/rebase.py @ 40366:b14fdf1fb615

update: clarify update() call sites by specifying argument names

merge.update() takes a lot of parameters and I get confused all the
time which is which.

Differential Revision: https://phab.mercurial-scm.org/D5153

40365:4f37af86d5d5

    if wctx.isinmemory():
        wctx.setbase(repo[p1])
    else:
        if repo['.'].rev() != p1:
            repo.ui.debug(" update to %d:%s\n" % (p1, repo[p1]))
            mergemod.update(repo, p1, False, True)
        else:
            repo.ui.debug(" already in destination\n")
        # This is, alas, necessary to invalidate workingctx's manifest cache,
        # as well as other data we litter on it in other places.
        wctx = repo[None]

    repo.ui.debug(" merge against %d:%s\n" % (rev, repo[rev]))
    if base is not None:
        repo.ui.debug("   detach base %d:%s\n" % (base, repo[base]))
    # When collapsing in-place, the parent is the common ancestor, we
    # have to allow merging with it.
    stats = mergemod.update(repo, rev, True, True, base, collapse,
                            labels=['dest', 'source'], wc=wctx)
    if collapse:
        copies.duplicatecopies(repo, wctx, rev, dest)
    else:
        # If we're not using --collapse, we need to

            updateifonnodes.add(originalwd)
            shouldupdate = repo['.'].rev() in updateifonnodes

            # Update away from the rebase if necessary
            if shouldupdate or needupdate(repo, state):
                mergemod.update(repo, originalwd, False, True)

            # Strip from the first rebased revision
            if rebased:
                repair.strip(repo.ui, repo, strippoints, backup=backup)

40366:b14fdf1fb615

    if wctx.isinmemory():
        wctx.setbase(repo[p1])
    else:
        if repo['.'].rev() != p1:
            repo.ui.debug(" update to %d:%s\n" % (p1, repo[p1]))
            mergemod.update(repo, p1, branchmerge=False, force=True)
        else:
            repo.ui.debug(" already in destination\n")
        # This is, alas, necessary to invalidate workingctx's manifest cache,
        # as well as other data we litter on it in other places.
        wctx = repo[None]

    repo.ui.debug(" merge against %d:%s\n" % (rev, repo[rev]))
    if base is not None:
        repo.ui.debug("   detach base %d:%s\n" % (base, repo[base]))
    # When collapsing in-place, the parent is the common ancestor, we
    # have to allow merging with it.
    stats = mergemod.update(repo, rev, branchmerge=True, force=True,
                            ancestor=base, mergeancestor=collapse,
                            labels=['dest', 'source'], wc=wctx)
    if collapse:
        copies.duplicatecopies(repo, wctx, rev, dest)
    else:
        # If we're not using --collapse, we need to

            updateifonnodes.add(originalwd)
            shouldupdate = repo['.'].rev() in updateifonnodes

            # Update away from the rebase if necessary
            if shouldupdate or needupdate(repo, state):
                mergemod.update(repo, originalwd, branchmerge=False, force=True)

            # Strip from the first rebased revision
            if rebased:
                repair.strip(repo.ui, repo, strippoints, backup=backup)