Mercurial > hg
comparison tests/test-phabricator.t @ 45246:b1f2659c1c34
phabricator: unconditionally pop `test_vcr` to fix debugcallconduit
11592ce6a711 / D8525 accidentally broke debugcallconduit in non-test scenarios
because it stopped popping `test_vcr` from `kwargs` unconditionally, so when
`--test-vcr` isn't set the empty string still gets passed down as the value of
`test_vcr` in `kwargs`. However unlike all the other commands debugcallconduit
doesn't have an `**opts` argument to receive it, so it aborts because of
invalid arguments.
Differential Revision: https://phab.mercurial-scm.org/D8852
author | Ian Moody <moz-ian@perix.co.uk> |
---|---|
date | Thu, 30 Jul 2020 16:58:38 +0100 |
parents | b4887d0680a4 |
children | 1a5d3e555c70 |
comparison
equal
deleted
inserted
replaced
45245:b4887d0680a4 | 45246:b1f2659c1c34 |
---|---|
22 > url = https://phab.mercurial-scm.org/ | 22 > url = https://phab.mercurial-scm.org/ |
23 > callsign = HG | 23 > callsign = HG |
24 > EOF | 24 > EOF |
25 $ VCR="$TESTDIR/phabricator" | 25 $ VCR="$TESTDIR/phabricator" |
26 | 26 |
27 BROKEN: debugcallconduit fails without --test-vcr: | 27 debugcallconduit doesn't claim invalid arguments without --test-vcr: |
28 $ echo '{}' | HGRCSKIPREPO= hg debugcallconduit 'conduit.ping' | 28 $ echo '{}' | HGRCSKIPREPO= hg debugcallconduit 'conduit.ping' |
29 hg debugcallconduit: invalid arguments | 29 abort: config phabricator.url is required |
30 hg debugcallconduit METHOD | |
31 | |
32 call Conduit API | |
33 | |
34 options: | |
35 | |
36 (use 'hg debugcallconduit -h' to show more help) | |
37 [255] | 30 [255] |
38 | 31 |
39 Error is handled reasonably. We override the phabtoken here so that | 32 Error is handled reasonably. We override the phabtoken here so that |
40 when you're developing changes to phabricator.py you can edit the | 33 when you're developing changes to phabricator.py you can edit the |
41 above config and have a real token in the test but not have to edit | 34 above config and have a real token in the test but not have to edit |