comparison hgext/histedit.py @ 18436:b38c10502af9

histedit: factor most commit creation in a function

Later commits add two important items to histedit:
- Obsolescence cycle prevention
- Proper phase conservation

Those logics must be applied to all simple operations (pick, edit, mess) and
will require verbose code.

So we introduce a new function that will provide an entry point for this new.
logic.

The function build a closure to have a clear distinction between commit
arguments and data provided to the function to fulfil its logic.

18435:8c019d2fd7c0

#  f, fold = use commit, but fold into previous commit (combines N and N-1)
#  d, drop = remove commit from history
#  m, mess = edit message without changing commit content
#
""")

def applychanges(ui, repo, ctx, opts):
    """Merge changeset from ctx (only) in the current working directory"""
    wcpar = repo.dirstate.parents()[0]
    if ctx.p1().node() == wcpar:

    stats = applychanges(ui, repo, oldctx, opts)
    if stats and stats[3] > 0:
        raise util.Abort(_('Fix up the change and run '
                           'hg histedit --continue'))
    # drop the second merge parent
    n = repo.commit(text=oldctx.description(), user=oldctx.user(),
                    date=oldctx.date(), extra=oldctx.extra())
    if n is None:
        ui.warn(_('%s: empty changeset\n')
                     % node.hex(ha))
        return ctx, []
    new = repo[n]

    if stats and stats[3] > 0:
        raise util.Abort(_('Fix up the change and run '
                           'hg histedit --continue'))
    message = oldctx.description() + '\n'
    message = ui.edit(message, ui.username())
    new = repo.commit(text=message, user=oldctx.user(), date=oldctx.date(),
                      extra=oldctx.extra())
    newctx = repo[new]
    if oldctx.node() != newctx.node():
        return newctx, [(oldctx.node(), (new,))]
    # We didn't make an edit, so just indicate no replaced nodes
    return newctx, []

            message = ctx.description() + '\n'
        if action in ('e', 'edit', 'm', 'mess'):
            editor = cmdutil.commitforceeditor
        else:
            editor = False
        new = repo.commit(text=message, user=ctx.user(),
                          date=ctx.date(), extra=ctx.extra(),
                          editor=editor)
        if new is not None:
            newchildren.append(new)

    replacements = []
    # track replacements

        # if nothing got rewritten there is not purpose for this function
        return
    moves = []
    for bk, old in sorted(repo._bookmarks.iteritems()):
        if old == oldtopmost:
            # special case ensure bookmark stay on tip. 
            #
            # This is arguably a feature and we may only want that for the
            # active bookmark. But the behavior is kept compatible with the old
            # version for now.
            moves.append((bk, newtopmost))

18436:b38c10502af9

#  f, fold = use commit, but fold into previous commit (combines N and N-1)
#  d, drop = remove commit from history
#  m, mess = edit message without changing commit content
#
""")

def commitfuncfor(repo, src):
    """Build a commit function for the replacement of <src>

    This function ensure we apply the same treatement to all changesets.

    No such treatment is done yet.

    Note that fold have its own separated logic because its handling is a bit
    different and not easily factored out of the fold method.
    """
    def commitfunc(**kwargs):
        return repo.commit(**kwargs)
    return commitfunc



def applychanges(ui, repo, ctx, opts):
    """Merge changeset from ctx (only) in the current working directory"""
    wcpar = repo.dirstate.parents()[0]
    if ctx.p1().node() == wcpar:

    stats = applychanges(ui, repo, oldctx, opts)
    if stats and stats[3] > 0:
        raise util.Abort(_('Fix up the change and run '
                           'hg histedit --continue'))
    # drop the second merge parent
    commit = commitfuncfor(repo, oldctx)
    n = commit(text=oldctx.description(), user=oldctx.user(),
               date=oldctx.date(), extra=oldctx.extra())
    if n is None:
        ui.warn(_('%s: empty changeset\n')
                     % node.hex(ha))
        return ctx, []
    new = repo[n]

    if stats and stats[3] > 0:
        raise util.Abort(_('Fix up the change and run '
                           'hg histedit --continue'))
    message = oldctx.description() + '\n'
    message = ui.edit(message, ui.username())
    commit = commitfuncfor(repo, oldctx)
    new = commit(text=message, user=oldctx.user(), date=oldctx.date(),
                 extra=oldctx.extra())
    newctx = repo[new]
    if oldctx.node() != newctx.node():
        return newctx, [(oldctx.node(), (new,))]
    # We didn't make an edit, so just indicate no replaced nodes
    return newctx, []

            message = ctx.description() + '\n'
        if action in ('e', 'edit', 'm', 'mess'):
            editor = cmdutil.commitforceeditor
        else:
            editor = False
        commit = commitfuncfor(repo, ctx)
        new = commit(text=message, user=ctx.user(),
                     date=ctx.date(), extra=ctx.extra(),
                     editor=editor)
        if new is not None:
            newchildren.append(new)

    replacements = []
    # track replacements

        # if nothing got rewritten there is not purpose for this function
        return
    moves = []
    for bk, old in sorted(repo._bookmarks.iteritems()):
        if old == oldtopmost:
            # special case ensure bookmark stay on tip.
            #
            # This is arguably a feature and we may only want that for the
            # active bookmark. But the behavior is kept compatible with the old
            # version for now.
            moves.append((bk, newtopmost))