comparison mercurial/localrepo.py @ 39847:b504ff813c4f

localrepo: validate directories before creating any

There is no meaningful change in behavior because wdir would
already exist in the case where we raised RepoError. But I think
the code is easier to read if we do all validation first then
take actions with side-effects.

Differential Revision: https://phab.mercurial-scm.org/D4706

39846:d3e761f9ac0a

                          hint=_('is a required extension not loaded?'))

    requirements = newreporequirements(ui, createopts=createopts)

    wdirvfs = vfsmod.vfs(path, expandpath=True, realpath=True)
    if not wdirvfs.exists():
        wdirvfs.makedirs()

    hgvfs = vfsmod.vfs(wdirvfs.join(b'.hg'))
    if hgvfs.exists():
        raise error.RepoError(_('repository %s already exists') % path)

    hgvfs.makedir(notindexed=True)

    if b'store' in requirements:
        hgvfs.mkdir(b'store')

39847:b504ff813c4f

                          hint=_('is a required extension not loaded?'))

    requirements = newreporequirements(ui, createopts=createopts)

    wdirvfs = vfsmod.vfs(path, expandpath=True, realpath=True)

    hgvfs = vfsmod.vfs(wdirvfs.join(b'.hg'))
    if hgvfs.exists():
        raise error.RepoError(_('repository %s already exists') % path)

    if not wdirvfs.exists():
        wdirvfs.makedirs()

    hgvfs.makedir(notindexed=True)

    if b'store' in requirements:
        hgvfs.mkdir(b'store')