Mercurial > hg
comparison tests/test-check-py3-compat.t @ 30435:b86a448a2965
zstd: vendor python-zstandard 0.5.0
As the commit message for the previous changeset says, we wish
for zstd to be a 1st class citizen in Mercurial. To make that
happen, we need to enable Python to talk to the zstd C API. And
that requires bindings.
This commit vendors a copy of existing Python bindings. Why do we
need to vendor? As the commit message of the previous commit says,
relying on systems in the wild to have the bindings or zstd present
is a losing proposition. By distributing the zstd and bindings with
Mercurial, we significantly increase our chances that zstd will
work. Since zstd will deliver a better end-user experience by
achieving better performance, this benefits our users. Another
reason is that the Python bindings still aren't stable and the
API is somewhat fluid. While Mercurial could be coded to target
multiple versions of the Python bindings, it is safer to bundle
an explicit, known working version.
The added Python bindings are mostly a fully-featured interface
to the zstd C API. They allow one-shot operations, streaming,
reading and writing from objects implements the file object
protocol, dictionary compression, control over low-level compression
parameters, and more. The Python bindings work on Python 2.6,
2.7, and 3.3+ and have been tested on Linux and Windows. There are
CFFI bindings, but they are lacking compared to the C extension.
Upstream work will be needed before we can support zstd with PyPy.
But it will be possible.
The files added in this commit come from Git commit
e637c1b214d5f869cf8116c550dcae23ec13b677 from
https://github.com/indygreg/python-zstandard and are added without
modifications. Some files from the upstream repository have been
omitted, namely files related to continuous integration.
In the spirit of full disclosure, I'm the maintainer of the
"python-zstandard" project and have authored 100% of the code
added in this commit. Unfortunately, the Python bindings have
not been formally code reviewed by anyone. While I've tested
much of the code thoroughly (I even have tests that fuzz APIs),
there's a good chance there are bugs, memory leaks, not well
thought out APIs, etc. If someone wants to review the code and
send feedback to the GitHub project, it would be greatly
appreciated.
Despite my involvement with both projects, my opinions of code
style differ from Mercurial's. The code in this commit introduces
numerous code style violations in Mercurial's linters. So, the code
is excluded from most lints. However, some violations I agree with.
These have been added to the known violations ignore list for now.
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Thu, 10 Nov 2016 22:15:58 -0800 |
| parents | 776a6d29b2cc |
| children | 8b3ad0252344 |
comparison
equal
deleted
inserted
replaced
| 30434:2e484bdea8c4 | 30435:b86a448a2965 |
|---|---|
| 2 | 2 |
| 3 $ . "$TESTDIR/helpers-testrepo.sh" | 3 $ . "$TESTDIR/helpers-testrepo.sh" |
| 4 $ cd "$TESTDIR"/.. | 4 $ cd "$TESTDIR"/.. |
| 5 | 5 |
| 6 $ hg files 'set:(**.py)' | sed 's|\\|/|g' | xargs python contrib/check-py3-compat.py | 6 $ hg files 'set:(**.py)' | sed 's|\\|/|g' | xargs python contrib/check-py3-compat.py |
| 7 contrib/python-zstandard/setup.py not using absolute_import | |
| 8 contrib/python-zstandard/setup_zstd.py not using absolute_import | |
| 9 contrib/python-zstandard/tests/common.py not using absolute_import | |
| 10 contrib/python-zstandard/tests/test_cffi.py not using absolute_import | |
| 11 contrib/python-zstandard/tests/test_compressor.py not using absolute_import | |
| 12 contrib/python-zstandard/tests/test_data_structures.py not using absolute_import | |
| 13 contrib/python-zstandard/tests/test_decompressor.py not using absolute_import | |
| 14 contrib/python-zstandard/tests/test_estimate_sizes.py not using absolute_import | |
| 15 contrib/python-zstandard/tests/test_module_attributes.py not using absolute_import | |
| 16 contrib/python-zstandard/tests/test_roundtrip.py not using absolute_import | |
| 17 contrib/python-zstandard/tests/test_train_dictionary.py not using absolute_import | |
| 7 hgext/fsmonitor/pywatchman/__init__.py not using absolute_import | 18 hgext/fsmonitor/pywatchman/__init__.py not using absolute_import |
| 8 hgext/fsmonitor/pywatchman/__init__.py requires print_function | 19 hgext/fsmonitor/pywatchman/__init__.py requires print_function |
| 9 hgext/fsmonitor/pywatchman/capabilities.py not using absolute_import | 20 hgext/fsmonitor/pywatchman/capabilities.py not using absolute_import |
| 10 hgext/fsmonitor/pywatchman/pybser.py not using absolute_import | 21 hgext/fsmonitor/pywatchman/pybser.py not using absolute_import |
| 11 i18n/check-translation.py not using absolute_import | 22 i18n/check-translation.py not using absolute_import |