comparison setup.py @ 44603:bda050bc9987 stable

py3: make setup.py's hgcommand() consistently return bytes

Before this patch, it returned unicode when the command failed. That
made e.g. `make local PYTHON=python3` fail on an obsolete commit.

Differential Revision: https://phab.mercurial-scm.org/D8331

44594:c23877cb25a5

        returncode, out, err = runcmd(cmd, self.env)
        err = filterhgerr(err)
        if err or returncode != 0:
            printf("stderr from '%s':" % (' '.join(cmd)), file=sys.stderr)
            printf(err, file=sys.stderr)
            return ''
        return out


def filterhgerr(err):
    # If root is executing setup.py, but the repository is owned by

44603:bda050bc9987

        returncode, out, err = runcmd(cmd, self.env)
        err = filterhgerr(err)
        if err or returncode != 0:
            printf("stderr from '%s':" % (' '.join(cmd)), file=sys.stderr)
            printf(err, file=sys.stderr)
            return b''
        return out


def filterhgerr(err):
    # If root is executing setup.py, but the repository is owned by