comparison hgext/histedit.py @ 43933:bde97bee321f

histedit: use rewriteutil.precheck() instead of reimplementing it

We have had this nice utility since 490df753894d (rewriteutil: add a
precheck function to check if revs can be rewritten, 2017-11-24). We
got two callers soon thereafter, in 98f97eb20597 (rewriteutil: use
precheck() in uncommit and amend commands, 2017-11-28). It's about
time we use it in other places.

rewriteutil.precheck() looks unfortunate for i18n (it seems to rely on
an English verb for the action making sense in other languages), but
hopefully not bad enough that we should avoid using it.

Differential Revision: https://phab.mercurial-scm.org/D7684

43932:9fb9f3a5cad7

    node,
    obsolete,
    pycompat,
    registrar,
    repair,
    scmutil,
    state as statemod,
    util,
)
from mercurial.utils import (

    """select and validate the set of revision to edit

    When keep is false, the specified set can't have children."""
    revs = repo.revs(b'%n::%n', old, new)
    if revs and not keep:
        if not obsolete.isenabled(
            repo, obsolete.allowunstableopt
        ) and repo.revs(b'(%ld::) - (%ld)', revs, revs):
            raise error.Abort(
                _(
                    b'can only histedit a changeset together '
                    b'with all its descendants'
                )
            )
        if repo.revs(b'(%ld) and merge()', revs):
            raise error.Abort(_(b'cannot edit history that contains merges'))
        root = repo[revs.first()]  # list is already sorted by repo.revs()
        if not root.mutable():
            raise error.Abort(
                _(b'cannot edit public changeset: %s') % root,
                hint=_(b"see 'hg help phases' for details"),
            )
    return pycompat.maplist(repo.changelog.node, revs)


def ruleeditor(repo, ui, actions, editcomment=b""):
    """open an editor to edit rules

43933:bde97bee321f

    node,
    obsolete,
    pycompat,
    registrar,
    repair,
    rewriteutil,
    scmutil,
    state as statemod,
    util,
)
from mercurial.utils import (

    """select and validate the set of revision to edit

    When keep is false, the specified set can't have children."""
    revs = repo.revs(b'%n::%n', old, new)
    if revs and not keep:
        rewriteutil.precheck(repo, revs, b'edit')
        if repo.revs(b'(%ld) and merge()', revs):
            raise error.Abort(_(b'cannot edit history that contains merges'))
    return pycompat.maplist(repo.changelog.node, revs)


def ruleeditor(repo, ui, actions, editcomment=b""):
    """open an editor to edit rules