comparison mercurial/localrepo.py @ 24747:bef8b17443a3

develwarn: refactor the developer warning logic

The logic is currently duplicated and we plan to make it a bit smarter. So we
move it into a function first to make the update more robust and simple.

24746:e0c810d0ab69

    def transaction(self, desc, report=None):
        if (self.ui.configbool('devel', 'all')
                or self.ui.configbool('devel', 'check-locks')):
            l = self._lockref and self._lockref()
            if l is None or not l.held:
                msg = 'transaction with no lock\n'
                if self.ui.tracebackflag:
                    util.debugstacktrace(msg, 1)
                else:
                    self.ui.write_err(msg)
        tr = self.currenttransaction()
        if tr is not None:
            return tr.nest()

        # abort here if the journal already exists

        if (self.ui.configbool('devel', 'all')
                or self.ui.configbool('devel', 'check-locks')):
            l = self._lockref and self._lockref()
            if l is not None and l.held:
                msg = '"wlock" acquired after "lock"\n'
                if self.ui.tracebackflag:
                    util.debugstacktrace(msg, 1)
                else:
                    self.ui.write_err(msg)

        def unlock():
            if self.dirstate.pendingparentchange():
                self.dirstate.invalidate()
            else:

24747:bef8b17443a3

    def transaction(self, desc, report=None):
        if (self.ui.configbool('devel', 'all')
                or self.ui.configbool('devel', 'check-locks')):
            l = self._lockref and self._lockref()
            if l is None or not l.held:
                scmutil.develwarn(self.ui, 'transaction with no lock\n')
        tr = self.currenttransaction()
        if tr is not None:
            return tr.nest()

        # abort here if the journal already exists

        if (self.ui.configbool('devel', 'all')
                or self.ui.configbool('devel', 'check-locks')):
            l = self._lockref and self._lockref()
            if l is not None and l.held:
                scmutil.develwarn(self.ui, '"wlock" acquired after "lock"\n')

        def unlock():
            if self.dirstate.pendingparentchange():
                self.dirstate.invalidate()
            else: