Mercurial > hg
comparison tests/test-revert.t @ 30556:c059286a0f9c
tests: replace "cp -r" with "cp -R"
The POSIX documentation about "cp" [1] says:
....
RATIONALE
....
Earlier versions of this standard included support for the -r option to
copy file hierarchies. The -r option is historical practice on BSD and
BSD-derived systems. This option is no longer specified by POSIX.1-2008
but may be present in some implementations. The -R option was added as a
close synonym to the -r option, selected for consistency with all other
options in this volume of POSIX.1-2008 that do recursive directory
descent.
The difference between -R and the removed -r option is in the treatment
by cp of file types other than regular and directory. It was
implementation-defined how the - option treated special files to allow
both historical implementations and those that chose to support -r with
the same abilities as -R defined by this volume of POSIX.1-2008. The
original -r flag, for historic reasons, did not handle special files any
differently from regular files, but always read the file and copied its
contents. This had obvious problems in the presence of special file
types; for example, character devices, FIFOs, and sockets.
....
....
Issue 6
The -r option is marked obsolescent.
....
Issue 7
....
The obsolescent -r option is removed.
....
(No "Issue 8" yet)
Therefore it's clear that "cp -R" is strictly better than "cp -r".
The issue was discovered when running tests on OS X after 0d87b1caed92.
[1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html
author | Jun Wu <quark@fb.com> |
---|---|
date | Wed, 30 Nov 2016 19:25:18 +0000 |
parents | cb6a952efbf4 |
children | 75be14993fda |
comparison
equal
deleted
inserted
replaced
30555:6a672c3b7860 | 30556:c059286a0f9c |
---|---|
782 Test revert --all to parent content | 782 Test revert --all to parent content |
783 ----------------------------------- | 783 ----------------------------------- |
784 | 784 |
785 (setup from reference repo) | 785 (setup from reference repo) |
786 | 786 |
787 $ cp -r revert-ref revert-parent-all | 787 $ cp -R revert-ref revert-parent-all |
788 $ cd revert-parent-all | 788 $ cd revert-parent-all |
789 | 789 |
790 check revert output | 790 check revert output |
791 | 791 |
792 $ hg revert --all | 792 $ hg revert --all |
839 Test revert --all to "base" content | 839 Test revert --all to "base" content |
840 ----------------------------------- | 840 ----------------------------------- |
841 | 841 |
842 (setup from reference repo) | 842 (setup from reference repo) |
843 | 843 |
844 $ cp -r revert-ref revert-base-all | 844 $ cp -R revert-ref revert-base-all |
845 $ cd revert-base-all | 845 $ cd revert-base-all |
846 | 846 |
847 check revert output | 847 check revert output |
848 | 848 |
849 $ hg revert --all --rev 'desc(base)' | 849 $ hg revert --all --rev 'desc(base)' |
894 Test revert to parent content with explicit file name | 894 Test revert to parent content with explicit file name |
895 ----------------------------------------------------- | 895 ----------------------------------------------------- |
896 | 896 |
897 (setup from reference repo) | 897 (setup from reference repo) |
898 | 898 |
899 $ cp -r revert-ref revert-parent-explicit | 899 $ cp -R revert-ref revert-parent-explicit |
900 $ cd revert-parent-explicit | 900 $ cd revert-parent-explicit |
901 | 901 |
902 revert all files individually and check the output | 902 revert all files individually and check the output |
903 (output is expected to be different than in the --all case) | 903 (output is expected to be different than in the --all case) |
904 | 904 |
987 Test revert to "base" content with explicit file name | 987 Test revert to "base" content with explicit file name |
988 ----------------------------------------------------- | 988 ----------------------------------------------------- |
989 | 989 |
990 (setup from reference repo) | 990 (setup from reference repo) |
991 | 991 |
992 $ cp -r revert-ref revert-base-explicit | 992 $ cp -R revert-ref revert-base-explicit |
993 $ cd revert-base-explicit | 993 $ cd revert-base-explicit |
994 | 994 |
995 revert all files individually and check the output | 995 revert all files individually and check the output |
996 (output is expected to be different than in the --all case) | 996 (output is expected to be different than in the --all case) |
997 | 997 |