comparison mercurial/bundle2.py @ 43131:c17a63eb5d4c

sidedata: apply basic but tight security around exchange

We don't currently have code to deal with exchange between repository using
sidedata and repository not using sidedata. Until we implement such code (eg:
dropping side data when pushing to a non-sidedata repo) we prevent the two kind
of repo to speak to each other. This is somewhere similar to what 'treemanifest'
does.

Note that sidedata exchange is broken unless one use changegroup v3 anyway. See
next changeset for details.

Differential Revision: https://phab.mercurial-scm.org/D6939

43130:c88075eb28e3

            b'%ln and secret()', outgoing.missingheads
        ):
            part.addparam(
                b'targetphase', b'%d' % phases.secret, mandatory=False
            )

    if opts.get(b'streamv2', False):
        addpartbundlestream2(bundler, repo, stream=True)

    if opts.get(b'tagsfnodescache', True):

        result = -1 + changedheads
    return result


@parthandler(
    b'changegroup', (b'version', b'nbchanges', b'treemanifest', b'targetphase')
)
def handlechangegroup(op, inpart):
    """apply a changegroup part on the repo

    This is a very early implementation that will massive rework before being

        op.repo.requirements.add(b'treemanifest')
        op.repo.svfs.options = localrepo.resolvestorevfsoptions(
            op.repo.ui, op.repo.requirements, op.repo.features
        )
        op.repo._writerequirements()
    extrakwargs = {}
    targetphase = inpart.params.get(b'targetphase')
    if targetphase is not None:
        extrakwargs[r'targetphase'] = int(targetphase)
    ret = _processchangegroup(

        part = bundler.newpart(b'changegroup', data=cgdata)
        part.addparam(b'version', cgversion)
        if b'treemanifest' in repo.requirements:
            part.addparam(b'treemanifest', b'1')

    return bundler

43131:c17a63eb5d4c

            b'%ln and secret()', outgoing.missingheads
        ):
            part.addparam(
                b'targetphase', b'%d' % phases.secret, mandatory=False
            )
        if b'exp-sidedata-flag' in repo.requirements:
            part.addparam(b'exp-sidedata', b'1')

    if opts.get(b'streamv2', False):
        addpartbundlestream2(bundler, repo, stream=True)

    if opts.get(b'tagsfnodescache', True):

        result = -1 + changedheads
    return result


@parthandler(
    b'changegroup',
    (
        b'version',
        b'nbchanges',
        b'exp-sidedata',
        b'treemanifest',
        b'targetphase',
    ),
)
def handlechangegroup(op, inpart):
    """apply a changegroup part on the repo

    This is a very early implementation that will massive rework before being

        op.repo.requirements.add(b'treemanifest')
        op.repo.svfs.options = localrepo.resolvestorevfsoptions(
            op.repo.ui, op.repo.requirements, op.repo.features
        )
        op.repo._writerequirements()

    bundlesidedata = bool(b'exp-sidedata' in inpart.params)
    reposidedata = bool(b'exp-sidedata-flag' in op.repo.requirements)
    if reposidedata and not bundlesidedata:
        msg = b"repository is using sidedata but the bundle source do not"
        hint = b'this is currently unsupported'
        raise error.Abort(msg, hint=hint)

    extrakwargs = {}
    targetphase = inpart.params.get(b'targetphase')
    if targetphase is not None:
        extrakwargs[r'targetphase'] = int(targetphase)
    ret = _processchangegroup(

        part = bundler.newpart(b'changegroup', data=cgdata)
        part.addparam(b'version', cgversion)
        if b'treemanifest' in repo.requirements:
            part.addparam(b'treemanifest', b'1')
        if b'exp-sidedata-flag' in repo.requirements:
            part.addparam(b'exp-sidedata', b'1')

    return bundler