comparison mercurial/upgrade.py @ 44746:c36a3fcfc36b stable

upgrade: properly filter action depending on planned work

The `determineactions` function filters out deficiency that are not scheduled to
be fixed by the target repository configuration. However it only did so for
requirement we currently support, letting other actions for unsupported
requirement through even if the target repo configuration did not request it.

As a result the output of the command was easily polluted by experimental
feature with no upgrade support.

We rework the code to still filter out requirement based action without the
faulty filtering.

Differential Revision: https://phab.mercurial-scm.org/D8427

44745:b4537125eb3c

    Returns a list of action names.
    """
    newactions = []

    knownreqs = supporteddestrequirements(repo)

    for d in deficiencies:
        name = d.name

        # If the action is a requirement that doesn't show up in the
        # destination requirements, prune the action.
        if name in knownreqs and name not in destreqs:
            continue

        newactions.append(d)

    # FUTURE consider adding some optimizations here for certain transitions.

44746:c36a3fcfc36b

    Returns a list of action names.
    """
    newactions = []

    for d in deficiencies:
        name = d._requirement

        # If the action is a requirement that doesn't show up in the
        # destination requirements, prune the action.
        if name is not None and name not in destreqs:
            continue

        newactions.append(d)

    # FUTURE consider adding some optimizations here for certain transitions.