comparison tests/run-tests.py @ 47775:c405c089611a stable

run-tests: do not inherit file descriptor when running a command This is one of the difference between python2 and python3 and could have been a reason why test hang with python2 + chg. This does not seems to help the hanging issue at all… However, now that this is written lets reduce the difference between python2 and python3. Differential Revision: https://phab.mercurial-scm.org/D11226
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Wed, 28 Jul 2021 14:56:10 +0200
parents e1130abae834
children 036b9b3cc79a
comparison
equal deleted inserted replaced
47774:fb8389f227a0 47775:c405c089611a
1585 """ 1585 """
1586 if self._debug: 1586 if self._debug:
1587 proc = subprocess.Popen( 1587 proc = subprocess.Popen(
1588 _bytes2sys(cmd), 1588 _bytes2sys(cmd),
1589 shell=True, 1589 shell=True,
1590 close_fds=closefds,
1590 cwd=_bytes2sys(self._testtmp), 1591 cwd=_bytes2sys(self._testtmp),
1591 env=env, 1592 env=env,
1592 ) 1593 )
1593 ret = proc.wait() 1594 ret = proc.wait()
1594 return (ret, None) 1595 return (ret, None)