comparison setup.py @ 50762:c51b178b0b7e

configitems: declare items in a TOML file Mercurial ships with Rust code that also needs to read from the config. Having a way of presenting `configitems` to both Python and Rust is needed to prevent duplication, drift, and have the appropriate devel warnings. Abstracting away from Python means choosing a config format. No single format is perfect, and I have yet to come across a developer that doesn't hate all of them in some way. Since we have a strict no-dependencies policy for Mercurial, we either need to use whatever comes with Python, vendor a library, or implement a custom format ourselves. Python stdlib means using JSON, which doesn't support comments and isn't great for humans, or `configparser` which is an obscure, untyped format that nobody uses and doesn't have a commonplace Rust parser. Implementing a custom format is error-prone, tedious and subject to the same issues as picking an existing format. Vendoring opens us to the vast array of common config formats. The ones being picked for most modern software are YAML and TOML. YAML is older and common in the Python community, but TOML is much simpler and less error-prone. I would much rather be responsible for the <1000 lines of `tomli`, on top of TOML being the choice of the Rust community, with robust crates for reading it. The structure of `configitems.toml` is explained inline.
author Raphaël Gomès <rgomes@octobus.net>
date Mon, 23 Jan 2023 18:08:11 +0100
parents 2c34c9b61a4f
children 609a3b8058c3
comparison
equal deleted inserted replaced
50761:2c34c9b61a4f 50762:c51b178b0b7e
1642 1642
1643 msvccompiler.MSVCCompiler = HackedMSVCCompiler 1643 msvccompiler.MSVCCompiler = HackedMSVCCompiler
1644 1644
1645 packagedata = { 1645 packagedata = {
1646 'mercurial': [ 1646 'mercurial': [
1647 'configitems.toml',
1647 'locale/*/LC_MESSAGES/hg.mo', 1648 'locale/*/LC_MESSAGES/hg.mo',
1648 'dummycert.pem', 1649 'dummycert.pem',
1649 ], 1650 ],
1650 'mercurial.defaultrc': [ 1651 'mercurial.defaultrc': [
1651 '*.rc', 1652 '*.rc',