comparison mercurial/merge.py @ 45296:cb0cd87e16b4

merge: unify logic of couple of if-else's in manifestmerge()

Right now manifestmerge() contains very nested if-else conditions and it's not
easy to understand what is happening. I was looking for easy unifications and
found these two.

Differential Revision: https://phab.mercurial-scm.org/D8834

45295:6a8eafaeff3b

            if f not in ma:
                # TODO: what if they're renamed from different sources?
                fa = branch_copies1.copy.get(
                    f, None
                ) or branch_copies2.copy.get(f, None)
                if fa is not None:
                    mresult.addfile(
                        f,
                        mergestatemod.ACTION_MERGE,
                        (f, f, fa, False, pa.node()),
                        b'both renamed from %s' % fa,
                    )
                else:
                    mresult.addfile(
                        f,
                        mergestatemod.ACTION_MERGE,
                        (f, f, None, False, pa.node()),
                        b'both created',
                    )
            else:
                a = ma[f]
                fla = ma.flags(f)
                nol = b'l' not in fl1 + fl2 + fla
                if n2 == a and fl2 == fla:

                        (f, fl2),
                        b'local directory rename - get from %s' % f,
                    )
            elif f in branch_copies2.copy:
                f2 = branch_copies2.copy[f]
                if f2 in m2:
                    mresult.addfile(
                        f,
                        mergestatemod.ACTION_MERGE,
                        (f2, f, f2, False, pa.node()),
                        b'remote copied from %s' % f2,
                    )
                else:
                    mresult.addfile(
                        f,
                        mergestatemod.ACTION_MERGE,
                        (f2, f, f2, True, pa.node()),
                        b'remote moved from %s' % f2,
                    )
            elif f not in ma:
                # local unknown, remote created: the logic is described by the
                # following table:
                #
                # force  branchmerge  different  |  action

45296:cb0cd87e16b4

            if f not in ma:
                # TODO: what if they're renamed from different sources?
                fa = branch_copies1.copy.get(
                    f, None
                ) or branch_copies2.copy.get(f, None)
                args, msg = None, None
                if fa is not None:
                    args = (f, f, fa, False, pa.node())
                    msg = b'both renamed from %s' % fa
                else:
                    args = (f, f, None, False, pa.node())
                    msg = b'both created'
                mresult.addfile(f, mergestatemod.ACTION_MERGE, args, msg)
            else:
                a = ma[f]
                fla = ma.flags(f)
                nol = b'l' not in fl1 + fl2 + fla
                if n2 == a and fl2 == fla:

                        (f, fl2),
                        b'local directory rename - get from %s' % f,
                    )
            elif f in branch_copies2.copy:
                f2 = branch_copies2.copy[f]
                msg, args = None, None
                if f2 in m2:
                    args = (f2, f, f2, False, pa.node())
                    msg = b'remote copied from %s' % f2
                else:
                    args = (f2, f, f2, True, pa.node())
                    msg = b'remote moved from %s' % f2
                mresult.addfile(f, mergestatemod.ACTION_MERGE, args, msg)
            elif f not in ma:
                # local unknown, remote created: the logic is described by the
                # following table:
                #
                # force  branchmerge  different  |  action