comparison hgext/rebase.py @ 44349:cd43cae79f25

rebase: remove some now-unused parent arguments Differential Revision: https://phab.mercurial-scm.org/D7829
author Martin von Zweigbergk <martinvonz@google.com>
date Fri, 10 Jan 2020 17:20:12 -0800
parents 8082a77cc3a2
children f0021fbedea9
comparison
equal deleted inserted replaced
44348:8082a77cc3a2 44349:cd43cae79f25
504 for rev in sortedrevs: 504 for rev in sortedrevs:
505 self._rebasenode(tr, rev, allowdivergence, progress) 505 self._rebasenode(tr, rev, allowdivergence, progress)
506 p.complete() 506 p.complete()
507 ui.note(_(b'rebase merging completed\n')) 507 ui.note(_(b'rebase merging completed\n'))
508 508
509 def _concludenode(self, rev, p1, p2, editor, commitmsg=None): 509 def _concludenode(self, rev, p1, editor, commitmsg=None):
510 '''Commit the wd changes with parents p1 and p2. 510 '''Commit the wd changes with parents p1 and p2.
511 511
512 Reuse commit info from rev but also store useful information in extra. 512 Reuse commit info from rev but also store useful information in extra.
513 Return node of committed revision.''' 513 Return node of committed revision.'''
514 repo = self.repo 514 repo = self.repo
528 overrides[(b'ui', b'allowemptycommit')] = True 528 overrides[(b'ui', b'allowemptycommit')] = True
529 with repo.ui.configoverride(overrides, b'rebase'): 529 with repo.ui.configoverride(overrides, b'rebase'):
530 if self.inmemory: 530 if self.inmemory:
531 newnode = commitmemorynode( 531 newnode = commitmemorynode(
532 repo, 532 repo,
533 p1,
534 p2,
535 wctx=self.wctx, 533 wctx=self.wctx,
536 extra=extra, 534 extra=extra,
537 commitmsg=commitmsg, 535 commitmsg=commitmsg,
538 editor=editor, 536 editor=editor,
539 user=ctx.user(), 537 user=ctx.user(),
541 ) 539 )
542 mergemod.mergestate.clean(repo) 540 mergemod.mergestate.clean(repo)
543 else: 541 else:
544 newnode = commitnode( 542 newnode = commitnode(
545 repo, 543 repo,
546 p1,
547 p2,
548 extra=extra, 544 extra=extra,
549 commitmsg=commitmsg, 545 commitmsg=commitmsg,
550 editor=editor, 546 editor=editor,
551 user=ctx.user(), 547 user=ctx.user(),
552 date=date, 548 date=date,
638 merging = p2 != nullrev 634 merging = p2 != nullrev
639 editform = cmdutil.mergeeditform(merging, b'rebase') 635 editform = cmdutil.mergeeditform(merging, b'rebase')
640 editor = cmdutil.getcommiteditor( 636 editor = cmdutil.getcommiteditor(
641 editform=editform, **pycompat.strkwargs(opts) 637 editform=editform, **pycompat.strkwargs(opts)
642 ) 638 )
643 newnode = self._concludenode(rev, p1, p2, editor) 639 newnode = self._concludenode(rev, p1, editor)
644 else: 640 else:
645 # Skip commit if we are collapsing 641 # Skip commit if we are collapsing
646 newnode = None 642 newnode = None
647 # Update the state 643 # Update the state
648 if newnode is not None: 644 if newnode is not None:
697 editor = cmdutil.getcommiteditor(edit=editopt, editform=editform) 693 editor = cmdutil.getcommiteditor(edit=editopt, editform=editform)
698 revtoreuse = max(self.state) 694 revtoreuse = max(self.state)
699 695
700 self.wctx.setparents(repo[p1].node(), repo[self.external].node()) 696 self.wctx.setparents(repo[p1].node(), repo[self.external].node())
701 newnode = self._concludenode( 697 newnode = self._concludenode(
702 revtoreuse, p1, self.external, editor, commitmsg=commitmsg 698 revtoreuse, p1, editor, commitmsg=commitmsg
703 ) 699 )
704 700
705 if newnode is not None: 701 if newnode is not None:
706 newrev = repo[newnode].rev() 702 newrev = repo[newnode].rev()
707 for oldrev in self.state: 703 for oldrev in self.state:
1419 ) 1415 )
1420 % (max(destancestors), b', '.join(b"%d" % p for p in sorted(parents))) 1416 % (max(destancestors), b', '.join(b"%d" % p for p in sorted(parents)))
1421 ) 1417 )
1422 1418
1423 1419
1424 def commitmemorynode(repo, p1, p2, wctx, editor, extra, user, date, commitmsg): 1420 def commitmemorynode(repo, wctx, editor, extra, user, date, commitmsg):
1425 '''Commit the memory changes with parents p1 and p2. 1421 '''Commit the memory changes with parents p1 and p2.
1426 Return node of committed revision.''' 1422 Return node of committed revision.'''
1427 # Replicates the empty check in ``repo.commit``. 1423 # Replicates the empty check in ``repo.commit``.
1428 if wctx.isempty() and not repo.ui.configbool(b'ui', b'allowemptycommit'): 1424 if wctx.isempty() and not repo.ui.configbool(b'ui', b'allowemptycommit'):
1429 return None 1425 return None
1445 commitres = repo.commitctx(memctx) 1441 commitres = repo.commitctx(memctx)
1446 wctx.clean() # Might be reused 1442 wctx.clean() # Might be reused
1447 return commitres 1443 return commitres
1448 1444
1449 1445
1450 def commitnode(repo, p1, p2, editor, extra, user, date, commitmsg): 1446 def commitnode(repo, editor, extra, user, date, commitmsg):
1451 '''Commit the wd changes with parents p1 and p2. 1447 '''Commit the wd changes with parents p1 and p2.
1452 Return node of committed revision.''' 1448 Return node of committed revision.'''
1453 dsguard = util.nullcontextmanager() 1449 dsguard = util.nullcontextmanager()
1454 if not repo.ui.configbool(b'rebase', b'singletransaction'): 1450 if not repo.ui.configbool(b'rebase', b'singletransaction'):
1455 dsguard = dirstateguard.dirstateguard(repo, b'rebase') 1451 dsguard = dirstateguard.dirstateguard(repo, b'rebase')