comparison mercurial/httppeer.py @ 30484:d1b97fc87f55

httppeer: document why super() isn't used

Adding a follow-up to document lack of super() per Augie's
request.

30483:8491845a75b2

    except httplib.HTTPException:
        raise IOError(None, _('connection ended unexpectedly'))

    # We need to wrap reader.read() so HTTPException on subsequent
    # reads is also converted.
    origread = reader.read
    class readerproxy(reader.__class__):
        def read(self, *args, **kwargs):
            try:
                return origread(*args, **kwargs)

30484:d1b97fc87f55

    except httplib.HTTPException:
        raise IOError(None, _('connection ended unexpectedly'))

    # We need to wrap reader.read() so HTTPException on subsequent
    # reads is also converted.
    # Ideally we'd use super() here. However, if ``reader`` isn't a new-style
    # class, this can raise:
    # TypeError: super() argument 1 must be type, not classobj
    origread = reader.read
    class readerproxy(reader.__class__):
        def read(self, *args, **kwargs):
            try:
                return origread(*args, **kwargs)