comparison hgext/phabricator.py @ 42443:d3c81439e2ee

phabricator: auto-sanitise API tokens and HTTP cookies from VCR recordings

Currently when making VCR recordings one needs to manually sanitise sensitive
credentials before committing and submitting them as part of tests. It is easy
to imagine this being accidentally missed one time by a fallible human and said
credentials being leaked. It is also possible that it wouldn't be noticed to
alert the user to the leak since the recording files are so large and
practically unreviewable. Thus do so automatically, so the only place that needs
checking is in the test-phabricator.t file.

Differential Revision: https://phab.mercurial-scm.org/D6513

42442:c1bf63ac30c5

            return False
        r1params = r1.body.split(b'&')
        r2params = r2.body.split(b'&')
        return set(r1params) == set(r2params)

    def decorate(fn):
        def inner(*args, **kwargs):
            cassette = pycompat.fsdecode(kwargs.pop(r'test_vcr', None))
            if cassette:
                import hgdemandimport
                with hgdemandimport.deactivated():
                    import vcr as vcrmod
                    import vcr.stubs as stubs
                    vcr = vcrmod.VCR(
                        serializer=r'json',
                        custom_patches=[
                            (urlmod, r'httpconnection',
                             stubs.VCRHTTPConnection),
                            (urlmod, r'httpsconnection',
                             stubs.VCRHTTPSConnection),

42443:d3c81439e2ee

            return False
        r1params = r1.body.split(b'&')
        r2params = r2.body.split(b'&')
        return set(r1params) == set(r2params)

    def sanitiserequest(request):
        request.body = re.sub(
            r'cli-[a-z0-9]+',
            r'cli-hahayouwish',
            request.body
        )
        return request

    def sanitiseresponse(response):
        if r'set-cookie' in response[r'headers']:
            del response[r'headers'][r'set-cookie']
        return response

    def decorate(fn):
        def inner(*args, **kwargs):
            cassette = pycompat.fsdecode(kwargs.pop(r'test_vcr', None))
            if cassette:
                import hgdemandimport
                with hgdemandimport.deactivated():
                    import vcr as vcrmod
                    import vcr.stubs as stubs
                    vcr = vcrmod.VCR(
                        serializer=r'json',
                        before_record_request=sanitiserequest,
                        before_record_response=sanitiseresponse,
                        custom_patches=[
                            (urlmod, r'httpconnection',
                             stubs.VCRHTTPConnection),
                            (urlmod, r'httpsconnection',
                             stubs.VCRHTTPSConnection),