comparison mercurial/bookmarks.py @ 32737:d6924192c0d5

bookmarks: directly use base dict 'setitem'

The bmstore '__setitem__' method is setting an extra flag that is not needed
during initialization. Skipping the method will allow further cleanup and yield
some speedup as a side effect.

Before:
! wall 0.009120 comb 0.010000 user 0.010000 sys 0.000000 (best of 312)

After:
! wall 0.007874 comb 0.010000 user 0.010000 sys 0.000000 (best of 360)

32736:173f1bdc322d

    def __init__(self, repo):
        dict.__init__(self)
        self._repo = repo
        nm = repo.changelog.nodemap
        tonode = bin # force local lookup
        try:
            bkfile = _getbkfile(repo)
            for line in bkfile:
                line = line.strip()
                if not line:

                try:
                    sha, refspec = line.split(' ', 1)
                    node = tonode(sha)
                    if node in nm:
                        refspec = encoding.tolocal(refspec)
                        self[refspec] = node
                except (TypeError, ValueError):
                    # - bin(...) can raise TypeError
                    # - node in nm can raise ValueError for non-20-bytes entry
                    # - split(...) can raise ValueError for string without ' '
                    repo.ui.warn(_('malformed line in .hg/bookmarks: %r\n')

32737:d6924192c0d5

    def __init__(self, repo):
        dict.__init__(self)
        self._repo = repo
        nm = repo.changelog.nodemap
        tonode = bin # force local lookup
        setitem = dict.__setitem__
        try:
            bkfile = _getbkfile(repo)
            for line in bkfile:
                line = line.strip()
                if not line:

                try:
                    sha, refspec = line.split(' ', 1)
                    node = tonode(sha)
                    if node in nm:
                        refspec = encoding.tolocal(refspec)
                        setitem(self, refspec, node)
                except (TypeError, ValueError):
                    # - bin(...) can raise TypeError
                    # - node in nm can raise ValueError for non-20-bytes entry
                    # - split(...) can raise ValueError for string without ' '
                    repo.ui.warn(_('malformed line in .hg/bookmarks: %r\n')